Commit 555e677e authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

[Perf] Have v8.runtime_stats.top_25 use runtimeStatsTotalMetric.

It used to use runtimeStatsMetric but this seems broken, so move to
runtimeStatsTotalMetric instead.

Perf Sheriffs: This is expected to change all the metrics on
v8.runtime_stats.top_25 due to the change in measurements.

BUG=chromium:688342

Change-Id: I3e185fa9086e69151f4c5fa2db5fbf3d326d93fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771611Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691081}
parent 90e84c72
......@@ -32,27 +32,13 @@ class V8Top25RuntimeStats(perf_benchmark.PerfBenchmark):
'--enable-blink-features=BlinkRuntimeCallStats')
def CreateCoreTimelineBasedMeasurementOptions(self):
# TODO(fmeawad): most of the cat_filter information is extracted from
# page_cycler_v2 TimelineBasedMeasurementOptionsForLoadingMetric because
# used by the loadingMetric because the runtimeStatsMetric uses the
# interactive time calculated internally by the loadingMetric.
# It is better to share the code so that we can keep them in sync.
cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
# "blink.console" is used for marking ranges in
# cache_temperature.MarkTelemetryInternal.
cat_filter.AddIncludedCategory('blink.console')
# "navigation" and "blink.user_timing" are needed to capture core
# navigation events.
cat_filter.AddIncludedCategory('navigation')
cat_filter.AddIncludedCategory('blink.user_timing')
# "loading" is needed for first-meaningful-paint computation.
cat_filter.AddIncludedCategory('loading')
# "toplevel" category is used to capture TaskQueueManager events
# necessary to compute time-to-interactive.
# "toplevel" category is used to capture TaskQueueManager events.
cat_filter.AddIncludedCategory('toplevel')
# V8 needed categories
......@@ -61,7 +47,7 @@ class V8Top25RuntimeStats(perf_benchmark.PerfBenchmark):
tbm_options = timeline_based_measurement.Options(
overhead_level=cat_filter)
tbm_options.SetTimelineBasedMetrics(['runtimeStatsMetric'])
tbm_options.SetTimelineBasedMetrics(['runtimeStatsTotalMetric'])
return tbm_options
def CreateStorySet(self, options):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment