Commit 558ed636 authored by Mirko Bonadei's avatar Mirko Bonadei Committed by Commit Bot

Revert "Remove duplicate symbols in .def for absl.dll"

This reverts commit b51cc5df.

Reason for revert: Reverting the component build, see crbug.com/1098761.

Original change's description:
> Remove duplicate symbols in .def for absl.dll
>
> Bug: None
> Change-Id: I89c105a652db701c083a03f1c0c891e00d2e6776
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260754
> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
> Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781413}

TBR=mbonadei@chromium.org,danilchap@chromium.org

Change-Id: I85e28005c25270b150503c0f889363e47c4c2ad1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1098761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264125Reviewed-by: default avatarMirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781887}
parent 008317ec
......@@ -35,22 +35,20 @@ component("absl") {
public_deps = [
"//third_party/abseil-cpp/absl/algorithm:container",
"//third_party/abseil-cpp/absl/base",
"//third_party/abseil-cpp/absl/base:config",
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/container:inlined_vector",
# Disabled because of static initializers:
# "//third_party/abseil-cpp/absl/debugging:failure_signal_handler",
# "//third_party/abseil-cpp/absl/debugging:symbolize",
"//third_party/abseil-cpp/absl/hash",
"//third_party/abseil-cpp/absl/memory",
"//third_party/abseil-cpp/absl/meta:type_traits",
"//third_party/abseil-cpp/absl/numeric:int128",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
"//third_party/abseil-cpp/absl/types:span",
"//third_party/abseil-cpp/absl/types:variant",
# Disabled because of static initializers:
# "//third_party/abseil-cpp/absl/debugging:failure_signal_handler",
# "//third_party/abseil-cpp/absl/debugging:symbolize",
]
}
......
......@@ -56,13 +56,13 @@ def _GenerateDefFile(cpu):
logging.info('[%s] Found %d object files.', cpu, len(obj_files))
absl_symbols = set()
absl_symbols = []
for f in obj_files:
stdout = subprocess.check_output(['llvm-nm-9', f], cwd=os.getcwd())
for line in stdout.splitlines():
match = re.match(ABSL_SYM_RE, line.decode('utf-8'))
if match:
absl_symbols.add(match.group('symbol'))
absl_symbols.append(match.group('symbol'))
logging.info('[%s] Found %d absl symbols.', cpu, len(absl_symbols))
......
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment