Commit 5616ad6a authored by Chris Palmer's avatar Chris Palmer Committed by Commit Bot

Remove the DevTools warning about Public-Key-Pins[-Report-Only].

Support for HPKP has now been removed since M72. Also, it was never widely
adopted (part of the reason for deprecating and removing it). This warning
likely serves no purpose now.

Bug: 941776
Change-Id: I76d5d5673099600f80078fc7b5d41d3d050a13a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632307Reviewed-by: default avatarJoel Einbinder <einbinder@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664376}
parent e2cf1d30
...@@ -535,20 +535,6 @@ SDK.NetworkDispatcher = class { ...@@ -535,20 +535,6 @@ SDK.NetworkDispatcher = class {
} }
} }
if ('public-key-pins' in lowercaseHeaders || 'public-key-pins-report-only' in lowercaseHeaders) {
if (!this._hpkpDomains)
this._hpkpDomains = new Set();
const parsed = new Common.ParsedURL(response.url);
if (parsed.isValid && !this._hpkpDomains.has(parsed.host)) {
this._hpkpDomains.add(parsed.host);
const message = Common.UIString(
'HTTP-Based Public Key Pinning is deprecated. Chrome 69 and later will ignore HPKP response headers. (Host: %s)',
parsed.host);
this._manager.dispatchEventToListeners(
SDK.NetworkManager.Events.MessageGenerated, {message: message, requestId: requestId, warning: true});
}
}
this._updateNetworkRequestWithResponse(networkRequest, response); this._updateNetworkRequestWithResponse(networkRequest, response);
this._updateNetworkRequest(networkRequest); this._updateNetworkRequest(networkRequest);
...@@ -827,10 +813,8 @@ SDK.NetworkDispatcher = class { ...@@ -827,10 +813,8 @@ SDK.NetworkDispatcher = class {
this._inflightRequestsByURL[networkRequest.url()] = networkRequest; this._inflightRequestsByURL[networkRequest.url()] = networkRequest;
// The following relies on the fact that loaderIds and requestIds are // The following relies on the fact that loaderIds and requestIds are
// globally unique and that the main request has them equal. // globally unique and that the main request has them equal.
if (networkRequest.loaderId === networkRequest.requestId()) { if (networkRequest.loaderId === networkRequest.requestId())
SDK.multitargetNetworkManager._inflightMainResourceRequests.set(networkRequest.requestId(), networkRequest); SDK.multitargetNetworkManager._inflightMainResourceRequests.set(networkRequest.requestId(), networkRequest);
delete this._hpkpDomains;
}
this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestStarted, networkRequest); this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestStarted, networkRequest);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment