Skip to content

GitLab

T
tangled
Commit 562c5482 authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot
Browse files
Options

Add parser and evaluation WPT for <number> and <integer> involving min/max() 

Bug: 978682
Change-Id: I03310f9116f66d3ec2248a357c209d704deb85cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764669Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689397}
parent c4f60987
Show whitespace changes
Inline Side-by-side
Showing with 145 additions and 0 deletions
third_party/blink/web_tests/external/wpt/css/css-values/minmax-integer-computed.html 0 → 100644
View file @ 562c5482
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css-values-4/#comp-func">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#integers">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#calc-range">
<link rel="author" title="Xiaocheng Hu" href="mailto:xiaochengh@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../support/computed-testcommon.js"></script>
<div id="target"></div>
<div id="reference"></div>
<script>
const property = 'z-index';
function test_integer_equals(value, expected) {
const reference = document.getElementById('reference');
reference.style[property] = '';
reference.style[property] = expected;
const computed = getComputedStyle(reference)[property];
test_computed_value(property, value, computed);
}
// Identity tests
test_integer_equals('min(1)', '1');
test_integer_equals('max(1)', '1');
// Rounding
test_integer_equals('min(0.4)', '0');
test_integer_equals('min(0.6)', '1');
test_integer_equals('max(0.4)', '0');
test_integer_equals('max(0.6)', '1');
// Rounding and nesting
test_integer_equals('min(1.1, max(0.4, 0.6))', '1');
test_integer_equals('max(0.3, min(1.1, 0.4))', '0');
// No rounding at intermediate steps
test_integer_equals('calc(min(0.3, 0.6) * 2)', '1');
test_integer_equals('calc(max(0.3, 0.6) / 2)', '0');
</script>
third_party/blink/web_tests/external/wpt/css/css-values/minmax-number-computed.html 0 → 100644
View file @ 562c5482
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css-values-4/#comp-func">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#numbers">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#calc-type-checking">
<link rel="author" title="Xiaocheng Hu" href="mailto:xiaochengh@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../support/computed-testcommon.js"></script>
<div id="target"></div>
<div id="reference"></div>
<script>
const property = 'opacity';
function test_number_equals(value, expected) {
const reference = document.getElementById('reference');
reference.style[property] = '';
reference.style[property] = expected;
const computed = getComputedStyle(reference)[property];
test_computed_value(property, value, computed);
}
// Identity tests
test_number_equals('min(1)', '1');
test_number_equals('max(1)', '1');
// Nestings
test_number_equals('min(0.2, max(0.1, 0.15))', '0.15');
test_number_equals('max(0.1, min(0.2, 0.15))', '0.15');
// General calculations
test_number_equals('calc(min(0.1, 0.2) + 0.05)', '0.15');
test_number_equals('calc(min(0.1, 0.2) - 0.05)', '0.05');
test_number_equals('calc(min(0.1, 0.2) * 2)', '0.2');
test_number_equals('calc(min(0.1, 0.2) / 2)', '0.05');
test_number_equals('calc(max(0.1, 0.2) + 0.05)', '0.25');
test_number_equals('calc(max(0.1, 0.2) - 0.05)', '0.15');
test_number_equals('calc(max(0.1, 0.2) * 2)', '0.4');
test_number_equals('calc(max(0.1, 0.2) / 2)', '0.1');
test_number_equals('calc(min(0.1, 0.2) + max(0.1, 0.05))', '0.2');
test_number_equals('calc(min(0.1, 0.2) - max(0.1, 0.05))', '0');
</script>
third_party/blink/web_tests/external/wpt/css/css-values/minmax-number-invalid.html 0 → 100644
View file @ 562c5482
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css-values-4/#comp-func">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#numbers">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#calc-type-checking">
<link rel="author" title="Xiaocheng Hu" href="mailto:xiaochengh@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../support/parsing-testcommon.js"></script>
<script>
function test_invalid_number(value) {
test_invalid_value('opacity', value);
}
// Syntax checking
test_invalid_number('min()');
test_invalid_number('min( )');
test_invalid_number('min(,)');
test_invalid_number('min(1, )');
test_invalid_number('min(, 1)');
test_invalid_number('min(1 + )');
test_invalid_number('min(1 - )');
test_invalid_number('min(1 * )');
test_invalid_number('min(1 / )');
test_invalid_number('min(1 2)');
test_invalid_number('min(1, , 2)');
test_invalid_number('max()');
test_invalid_number('max( )');
test_invalid_number('max(,)');
test_invalid_number('max(1, )');
test_invalid_number('max(, 1)');
test_invalid_number('max(1 + )');
test_invalid_number('max(1 - )');
test_invalid_number('max(1 * )');
test_invalid_number('max(1 / )');
test_invalid_number('max(1 2)');
test_invalid_number('max(1, , 2)');
// Type checking
test_invalid_number('min(0px)');
test_invalid_number('min(0s)');
test_invalid_number('min(0deg)');
test_invalid_number('min(0Hz)');
test_invalid_number('min(0dpi)');
test_invalid_number('min(0fr)');
test_invalid_number('min(1, 1%)');
test_invalid_number('min(1, 0px)');
test_invalid_number('min(1, 0s)');
test_invalid_number('min(1, 0deg)');
test_invalid_number('min(1, 0Hz)');
test_invalid_number('min(1, 0dpi)');
test_invalid_number('min(1, 0fr)');
test_invalid_number('max(0px)');
test_invalid_number('max(0s)');
test_invalid_number('max(0deg)');
test_invalid_number('max(0Hz)');
test_invalid_number('max(0dpi)');
test_invalid_number('max(0fr)');
test_invalid_number('max(1, 1%)');
test_invalid_number('max(1, 0px)');
test_invalid_number('max(1, 0s)');
test_invalid_number('max(1, 0deg)');
test_invalid_number('max(1, 0Hz)');
test_invalid_number('max(1, 0dpi)');
test_invalid_number('max(1, 0fr)');
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment