Skip to content

GitLab

T
tangled
Commit 569df7dc authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot
Browse files
Options

[LayoutNG] Rebaseline text failures from build 8803 

This patch rebaselines 2 text failures that look good from a
manual review of build 8803, and 5 removal that match to
their base expectations.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I0efe930ada47e46163be831d7814c50a132ba195
Reviewed-on: https://chromium-review.googlesource.com/1172231
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582521}
parent fcdcd05a
Hide whitespace changes
Inline Side-by-side
Showing with 406 additions and 154 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
View file @ 569df7dc
...@@ -23,7 +23,6 @@ crbug.com/450202 fast/multicol/span/overflow-on-multicol.html [ Skip ] ...@@ -23,7 +23,6 @@ crbug.com/450202 fast/multicol/span/overflow-on-multicol.html [ Skip ]
crbug.com/591099 fast/block/marquee-width-shrinks-to-fit-in-fixed-size-container.html [ Failure ] crbug.com/591099 fast/block/marquee-width-shrinks-to-fit-in-fixed-size-container.html [ Failure ]
# Whitespace differences only # Whitespace differences only
crbug.com/854889 accessibility/canvas-fallback-content-2.html [ Failure ]
# Wrong quirks mode line height for pattern <div><a><img></a></div> # Wrong quirks mode line height for pattern <div><a><img></a></div>
crbug.com/854840 fast/table/backgr_border-table-quirks-collapsed-border.html [ Failure ] crbug.com/854840 fast/table/backgr_border-table-quirks-collapsed-border.html [ Failure ]
...@@ -517,7 +516,6 @@ crbug.com/591099 paint/invalidation/line-flow-with-floats-6.html [ Failure ] ...@@ -517,7 +516,6 @@ crbug.com/591099 paint/invalidation/line-flow-with-floats-6.html [ Failure ]
crbug.com/591099 paint/invalidation/line-flow-with-floats-7.html [ Failure ] crbug.com/591099 paint/invalidation/line-flow-with-floats-7.html [ Failure ]
crbug.com/591099 paint/invalidation/line-flow-with-floats-9.html [ Failure ] crbug.com/591099 paint/invalidation/line-flow-with-floats-9.html [ Failure ]
crbug.com/824918 paint/invalidation/multicol/multicol-repaint.html [ Failure ] crbug.com/824918 paint/invalidation/multicol/multicol-repaint.html [ Failure ]
crbug.com/591099 paint/invalidation/offset-change-wrong-invalidation-with-float.html [ Failure ]
crbug.com/835484 paint/invalidation/outline/focus-continuations.html [ Failure ] crbug.com/835484 paint/invalidation/outline/focus-continuations.html [ Failure ]
crbug.com/835484 paint/invalidation/outline/focus-enable-continuations.html [ Failure ] crbug.com/835484 paint/invalidation/outline/focus-enable-continuations.html [ Failure ]
crbug.com/835484 paint/invalidation/outline/focus-layers.html [ Failure ] crbug.com/835484 paint/invalidation/outline/focus-layers.html [ Failure ]
......
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/canvas-fallback-content-2-expected.txt 0 → 100644
View file @ 569df7dc
Link Button Button Button
Focusable
Heading
ARIA button
ARIA disabled button
ARIA enabled button
ARIA required button
ARIA toggle button
ARIA link
This tests a number of different elements in canvas fallback content to make sure their accessible attributes are essentially identical to the corresponding elements outside of canvas fallback content.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
link1
PASS document.activeElement == element1 is true
link2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
button1
PASS document.activeElement == element1 is true
button2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
labeled-button1
PASS document.activeElement == element1 is true
labeled-button2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
button-with-title1
PASS document.activeElement == element1 is true
button-with-title2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
text1
PASS document.activeElement == element1 is true
text2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
checkbox1
PASS document.activeElement == element1 is true
checkbox2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
number1
PASS document.activeElement == element1 is true
number2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
radio1
PASS document.activeElement == element1 is true
radio2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
slider1
PASS document.activeElement == element1 is true
slider2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
submit1
PASS document.activeElement == element1 is true
submit2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
combobox1
PASS document.activeElement == element1 is true
combobox2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
listbox1
PASS document.activeElement == element1 is true
listbox2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
textarea1
PASS document.activeElement == element1 is true
textarea2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
focusable1
PASS document.activeElement == element1 is true
focusable2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
heading1
PASS document.activeElement == element1 is true
heading2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-button1
PASS document.activeElement == element1 is true
aria-button2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-disabledbutton1
PASS document.activeElement == element1 is true
aria-disabledbutton2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-enabledbutton1
PASS document.activeElement == element1 is true
aria-enabledbutton2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-requiredbutton1
PASS document.activeElement == element1 is true
aria-requiredbutton2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-togglebutton1
PASS document.activeElement == element1 is true
aria-togglebutton2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
aria-link1
PASS document.activeElement == element1 is true
aria-link2
PASS document.activeElement == element2 is true
PASS axElement2.role is axElement1.role
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.name is axElement1.name
PASS axElement2.description is axElement1.description
PASS axElement2.stringValue is axElement1.stringValue
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
PASS axElement2.intValue is axElement1.intValue
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue
PASS successfullyParsed is true
TEST COMPLETE
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/details-open-repaint-expected.txt deleted 100644 → 0
View file @ fcdcd05a
{
"layers": [
{
"name": "LayoutView #document",
"bounds": [800, 600],
"drawsContent": false,
"backgroundColor": "#FFFFFF"
},
{
"name": "Scrolling Layer",
"bounds": [800, 600],
"drawsContent": false
},
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutTextControl INPUT",
"rect": [8, 72, 181, 22],
"reason": "appeared"
},
{
"object": "LayoutDetailsMarker DIV id='details-marker'",
"rect": [8, 56, 11, 11],
"reason": "full"
}
]
}
]
}
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/multicol/multicol-with-text-expected.txt deleted 100644 → 0
View file @ fcdcd05a
{
"layers": [
{
"name": "LayoutView #document",
"bounds": [800, 600],
"drawsContent": false,
"backgroundColor": "#FFFFFF"
},
{
"name": "Scrolling Layer",
"bounds": [800, 600],
"drawsContent": false
},
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutMultiColumnFlowThread (anonymous)",
"rect": [488, 8, 80, 20],
"reason": "chunk appeared"
}
]
}
]
}
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/box/box-inline-resize-expected.txt → third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
View file @ 569df7dc
...@@ -18,19 +18,32 @@ ...@@ -18,19 +18,32 @@
"backgroundColor": "#FFFFFF", "backgroundColor": "#FFFFFF",
"paintInvalidations": [ "paintInvalidations": [
{ {
"object": "InlineTextBox 'Chromium'", "object": "LayoutNGBlockFlow (positioned) UL id='submenu'",
"rect": [40, 107, 113, 27], "rect": [48, 94, 40, 20],
"reason": "geometry" "reason": "chunk disappeared"
}, }
{ ]
"object": "InlineTextBox 'Chromium'", },
"rect": [8, 107, 113, 27], {
"reason": "geometry" "name": "LayoutNGListItem (floating) LI id='watches'",
}, "position": [30, 44],
"bounds": [7, 20]
},
{
"name": "LayoutInline (relative positioned) SPAN id='placeholder'",
"position": [48, 44],
"drawsContent": false,
"backfaceVisibility": "hidden"
},
{
"name": "LayoutNGListItem (relative positioned) (floating) LI id='menu'",
"position": [30, 44],
"bounds": [7, 20],
"paintInvalidations": [
{ {
"object": "LayoutImage IMG id='foo'", "object": "NGPhysicalTextFragment '\u2022 '",
"rect": [8, 88, 32, 32], "rect": [0, 0, 7, 19],
"reason": "appeared" "reason": "subtree"
} }
] ]
} }
......
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/relative-inline-positioned-movement-repaint-expected.txt deleted 100644 → 0
View file @ fcdcd05a
{
"layers": [
{
"name": "LayoutView #document",
"bounds": [800, 600],
"drawsContent": false,
"backgroundColor": "#FFFFFF"
},
{
"name": "Scrolling Layer",
"bounds": [800, 600],
"drawsContent": false
},
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutInline (relative positioned) DIV id='block'",
"position": [68, 7],
"bounds": [365, 21],
"backfaceVisibility": "hidden",
"paintInvalidations": [
{
"object": "LayoutInline (relative positioned) DIV id='block'",
"rect": [0, 0, 365, 21],
"reason": "paint property change"
}
]
}
]
}
third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt deleted 100644 → 0
View file @ fcdcd05a
{
"layers": [
{
"name": "LayoutView #document",
"bounds": [800, 600],
"drawsContent": false,
"backgroundColor": "#FFFFFF"
},
{
"name": "Scrolling Layer",
"bounds": [800, 600],
"drawsContent": false
},
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "InlineTextBox 'This is some text'",
"rect": [246, 89, 127, 46],
"reason": "disappeared"
},
{
"object": "InlineTextBox 'This is some text'",
"rect": [203, 336, 126, 45],
"reason": "appeared"
},
{
"object": "LayoutSVGRect rect id='rect'",
"rect": [108, 84, 105, 102],
"reason": "full"
},
{
"object": "LayoutSVGRect rect id='rect'",
"rect": [355, 125, 104, 104],
"reason": "full"
},
{
"object": "LayoutSVGImage image id='image'",
"rect": [352, 398, 99, 98],
"reason": "full"
},
{
"object": "LayoutSVGImage image id='image'",
"rect": [90, 207, 98, 99],
"reason": "full"
}
]
}
]
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment