Skip to content

GitLab

T
tangled
Commit 5705b469 authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot
Browse files
Options

WebUI NTP: update custom elements to use ntp- prefix 

Change-Id: I33d929e5f8292c97961d5c524d58be57c703d004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960780
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723653}
parent 7fe10ea9
Show whitespace changes
Inline Side-by-side
Showing with 13 additions and 13 deletions
chrome/browser/resources/new_tab_page/app.html
View file @ 5705b469
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
left: 16px; left: 16px;
} }
</style> </style>
<most-visited></most-visited> <ntp-most-visited></ntp-most-visited>
<dom-if if="[[showCustomizeDialog_]]" restamp> <dom-if if="[[showCustomizeDialog_]]" restamp>
<template> <template>
<ntp-customize-dialog on-close="onCustomizeDialogClose_"> <ntp-customize-dialog on-close="onCustomizeDialogClose_">
......
chrome/browser/resources/new_tab_page/app.js
View file @ 5705b469
...@@ -13,9 +13,9 @@ import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/poly ...@@ -13,9 +13,9 @@ import {html, PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/poly
import {BrowserProxy} from './browser_proxy.js'; import {BrowserProxy} from './browser_proxy.js';
class NewTabPageApp extends PolymerElement { class NewTabPageAppElement extends PolymerElement {
static get is() { static get is() {
return 'new-tab-page-app'; return 'ntp-app';
} }
static get template() { static get template() {
...@@ -56,4 +56,4 @@ class NewTabPageApp extends PolymerElement { ...@@ -56,4 +56,4 @@ class NewTabPageApp extends PolymerElement {
} }
} }
customElements.define(NewTabPageApp.is, NewTabPageApp); customElements.define(NewTabPageAppElement.is, NewTabPageAppElement);
chrome/browser/resources/new_tab_page/most_visited.js
View file @ 5705b469
...@@ -38,9 +38,9 @@ function toast(msgId) { ...@@ -38,9 +38,9 @@ function toast(msgId) {
getToastManager().show(loadTimeData.getString(msgId)); getToastManager().show(loadTimeData.getString(msgId));
} }
class MostVisited extends PolymerElement { class MostVisitedElement extends PolymerElement {
static get is() { static get is() {
return 'most-visited'; return 'ntp-most-visited';
} }
static get template() { static get template() {
...@@ -318,4 +318,4 @@ class MostVisited extends PolymerElement { ...@@ -318,4 +318,4 @@ class MostVisited extends PolymerElement {
} }
} }
customElements.define(MostVisited.is, MostVisited); customElements.define(MostVisitedElement.is, MostVisitedElement);
chrome/browser/resources/new_tab_page/new_tab_page.html
View file @ 5705b469
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
</style> </style>
</head> </head>
<body> <body>
<new-tab-page-app></new-tab-page-app> <ntp-app></ntp-app>
<script type="module" src="app.js"></script> <script type="module" src="app.js"></script>
<link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">
</body> </body>
......
chrome/test/data/webui/new_tab_page/app_test.js
View file @ 5705b469
...@@ -9,7 +9,7 @@ import {TestProxy} from 'chrome://test/new_tab_page/test_support.js'; ...@@ -9,7 +9,7 @@ import {TestProxy} from 'chrome://test/new_tab_page/test_support.js';
import {eventToPromise, flushTasks} from 'chrome://test/test_util.m.js'; import {eventToPromise, flushTasks} from 'chrome://test/test_util.m.js';
suite('NewTabPageAppTest', () => { suite('NewTabPageAppTest', () => {
/** @type {!NewTabPageApp} */ /** @type {!NewTabPageAppElement} */
let app; let app;
/** @type {TestProxy} */ /** @type {TestProxy} */
...@@ -24,7 +24,7 @@ suite('NewTabPageAppTest', () => { ...@@ -24,7 +24,7 @@ suite('NewTabPageAppTest', () => {
testProxy = new TestProxy(); testProxy = new TestProxy();
BrowserProxy.instance_ = testProxy; BrowserProxy.instance_ = testProxy;
app = document.createElement('new-tab-page-app'); app = document.createElement('ntp-app');
document.body.appendChild(app); document.body.appendChild(app);
toastManager = app.shadowRoot.querySelector('cr-toast-manager'); toastManager = app.shadowRoot.querySelector('cr-toast-manager');
......
chrome/test/data/webui/new_tab_page/customize_dialog_test.js
View file @ 5705b469
...@@ -11,7 +11,7 @@ import 'chrome://new-tab-page/customize_dialog.js'; ...@@ -11,7 +11,7 @@ import 'chrome://new-tab-page/customize_dialog.js';
import {flushTasks} from 'chrome://test/test_util.m.js'; import {flushTasks} from 'chrome://test/test_util.m.js';
suite('NewTabPageCustomizeDialogTest', () => { suite('NewTabPageCustomizeDialogTest', () => {
/** @type {!CustomizeDialog} */ /** @type {!CustomizeDialogElement} */
let customizeDialog; let customizeDialog;
setup(() => { setup(() => {
......
chrome/test/data/webui/new_tab_page/most_visited_test.js
View file @ 5705b469
...@@ -9,7 +9,7 @@ import {TestProxy} from 'chrome://test/new_tab_page/test_support.js'; ...@@ -9,7 +9,7 @@ import {TestProxy} from 'chrome://test/new_tab_page/test_support.js';
import {eventToPromise, flushTasks} from 'chrome://test/test_util.m.js'; import {eventToPromise, flushTasks} from 'chrome://test/test_util.m.js';
suite('NewTabPageMostVisitedTest', () => { suite('NewTabPageMostVisitedTest', () => {
/** @type {!MostVisited} */ /** @type {!MostVisitedElement} */
let mostVisited; let mostVisited;
/** @type {TestProxy} */ /** @type {TestProxy} */
...@@ -57,7 +57,7 @@ suite('NewTabPageMostVisitedTest', () => { ...@@ -57,7 +57,7 @@ suite('NewTabPageMostVisitedTest', () => {
testProxy = new TestProxy(); testProxy = new TestProxy();
BrowserProxy.instance_ = testProxy; BrowserProxy.instance_ = testProxy;
mostVisited = document.createElement('most-visited'); mostVisited = document.createElement('ntp-most-visited');
document.body.appendChild(mostVisited); document.body.appendChild(mostVisited);
toastManager = document.createElement('cr-toast-manager'); toastManager = document.createElement('cr-toast-manager');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment