Skip to content

GitLab

T
tangled
Commit 572cd3f0 authored by Daniel Cheng's avatar Daniel Cheng Committed by Commit Bot
Browse files
Options

[corb] Mark various StringPiece constants as constexpr 

Spotted from https://twitter.com/ericlaw/status/1163552434297483265l

Change-Id: Ieeff46753eb86ca811b2217d7f943bcd360e5155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763225
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: default avatarŁukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689061}
parent 9acb315a
Show whitespace changes
Inline Side-by-side
Showing with 5 additions and 4 deletions
services/network/cross_origin_read_blocking.cc
View file @ 572cd3f0
......@@ -344,7 +344,7 @@ SniffingResult CrossOriginReadBlocking::SniffForHTML(StringPiece data) {
// TODO(dsjang): Once CrossOriginReadBlocking is moved into the browser
// process, we should do single-thread checking here for the static
// initializer.
static const StringPiece kHtmlSignatures[] = {
static constexpr StringPiece kHtmlSignatures[] = {
StringPiece("<!doctype html"), // HTML5 spec
StringPiece("<script"), // HTML5 spec, Mozilla
StringPiece("<html"), // HTML5 spec, Mozilla
......@@ -384,7 +384,7 @@ SniffingResult CrossOriginReadBlocking::SniffForXML(base::StringPiece data) {
// process, we should do single-thread checking here for the static
// initializer.
AdvancePastWhitespace(&data);
static const StringPiece kXmlSignatures[] = {StringPiece("<?xml")};
static constexpr StringPiece kXmlSignatures[] = {StringPiece("<?xml")};
return MatchesSignature(&data, kXmlSignatures, base::size(kXmlSignatures),
base::CompareCase::SENSITIVE);
}
......@@ -466,7 +466,7 @@ SniffingResult CrossOriginReadBlocking::SniffForFetchOnlyResource(
// infinite loop. In either case, the prefix must create a guarantee that no
// matter what bytes follow it, the entire response would be worthless to
// execute as a <script>.
static const StringPiece kScriptBreakingPrefixes[] = {
static constexpr StringPiece kScriptBreakingPrefixes[] = {
// Parser breaker prefix.
//
// Built into angular.js (followed by a comma and a newline):
......@@ -486,7 +486,8 @@ SniffingResult CrossOriginReadBlocking::SniffForFetchOnlyResource(
// Infinite loops.
StringPiece("for(;;);"), // observed on facebook.com
StringPiece("while(1);"), StringPiece("for (;;);"),
StringPiece("while(1);"),
StringPiece("for (;;);"),
StringPiece("while (1);"),
};
SniffingResult has_parser_breaker = MatchesSignature(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment