GitLab

[Cleanup] Use WebContentsConsoleObserver in WebBundle browsertests

Update content/browser/web_package/web_bundle_browsertest.cc to use
WebContentsConsoleObserver instead of ConsoleObserverDelegate.
- This allows us to avoid overriding the existing WebContentsDelegate,
  if any (which can mask behavior unintentional changes).
- Avoids the need for a filter of "*"

Bonus cleanups:
Extract common functionality for awaiting a failed navigation and
extracting the console message; cuts down ~50 lines of duplicate code.

Bug: 1034150
Change-Id: I6b78a46ee8bb02f529ea44980f2aa97efa80d0d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980896Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727462}