Commit 583c5131 authored by Jacob DeWitt's avatar Jacob DeWitt Committed by Commit Bot

Add XRInputSource.profiles

For now, it will always be an empty array. Populating the array will
come in a later CL.

Bug: 979250
Change-Id: I7dabbec261f280d6937d57a9076033b3b7e09f3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724277Reviewed-by: default avatarAlexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682324}
parent 22eb2d02
...@@ -55,6 +55,7 @@ class XRInputSource : public ScriptWrappable, public Gamepad::Client { ...@@ -55,6 +55,7 @@ class XRInputSource : public ScriptWrappable, public Gamepad::Client {
XRSpace* targetRaySpace() const; XRSpace* targetRaySpace() const;
XRSpace* gripSpace() const; XRSpace* gripSpace() const;
Gamepad* gamepad() const { return gamepad_; } Gamepad* gamepad() const { return gamepad_; }
Vector<String> profiles() const { return profiles_; }
uint32_t source_id() const { return state_.source_id; } uint32_t source_id() const { return state_.source_id; }
...@@ -129,6 +130,7 @@ class XRInputSource : public ScriptWrappable, public Gamepad::Client { ...@@ -129,6 +130,7 @@ class XRInputSource : public ScriptWrappable, public Gamepad::Client {
Member<XRTargetRaySpace> target_ray_space_; Member<XRTargetRaySpace> target_ray_space_;
Member<XRGripSpace> grip_space_; Member<XRGripSpace> grip_space_;
Member<Gamepad> gamepad_; Member<Gamepad> gamepad_;
Vector<String> profiles_;
std::unique_ptr<TransformationMatrix> base_pose_matrix_; std::unique_ptr<TransformationMatrix> base_pose_matrix_;
......
...@@ -24,4 +24,5 @@ enum XRTargetRayMode { ...@@ -24,4 +24,5 @@ enum XRTargetRayMode {
[SameObject] readonly attribute XRSpace targetRaySpace; [SameObject] readonly attribute XRSpace targetRaySpace;
[SameObject] readonly attribute XRSpace? gripSpace; [SameObject] readonly attribute XRSpace? gripSpace;
[SameObject, Measure] readonly attribute Gamepad? gamepad; [SameObject, Measure] readonly attribute Gamepad? gamepad;
[SameObject] readonly attribute FrozenArray<DOMString> profiles;
}; };
This is a testharness.js-based test. This is a testharness.js-based test.
Found 202 tests; 199 PASS, 3 FAIL, 0 TIMEOUT, 0 NOTRUN. Found 202 tests; 200 PASS, 2 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup PASS idl_test setup
PASS Partial interface Navigator: original interface defined PASS Partial interface Navigator: original interface defined
PASS Partial dictionary WebGLContextAttributes: original dictionary defined PASS Partial dictionary WebGLContextAttributes: original dictionary defined
...@@ -145,7 +145,7 @@ PASS XRInputSource interface: attribute targetRayMode ...@@ -145,7 +145,7 @@ PASS XRInputSource interface: attribute targetRayMode
PASS XRInputSource interface: attribute targetRaySpace PASS XRInputSource interface: attribute targetRaySpace
PASS XRInputSource interface: attribute gripSpace PASS XRInputSource interface: attribute gripSpace
PASS XRInputSource interface: attribute gamepad PASS XRInputSource interface: attribute gamepad
FAIL XRInputSource interface: attribute profiles assert_true: The prototype object must have a property "profiles" expected true got false PASS XRInputSource interface: attribute profiles
PASS XRInputSourceArray interface: existence and properties of interface object PASS XRInputSourceArray interface: existence and properties of interface object
PASS XRInputSourceArray interface object length PASS XRInputSourceArray interface object length
PASS XRInputSourceArray interface object name PASS XRInputSourceArray interface object name
......
...@@ -10685,6 +10685,7 @@ interface XRInputSource ...@@ -10685,6 +10685,7 @@ interface XRInputSource
getter gamepad getter gamepad
getter gripSpace getter gripSpace
getter handedness getter handedness
getter profiles
getter targetRayMode getter targetRayMode
getter targetRaySpace getter targetRaySpace
method constructor method constructor
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment