WebApp: Add more checks of database is opened.

In next CLs: Add more started/shutdown checks in WebAppInstallFinalizer,
WebAppInstallManager, ManifestUpdateManager.

Bug: 1084939
Change-Id: I720cbdd79998e895f5b9171e3173f89c6977be6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210085
Auto-Submit: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770931}

chrome/browser/web_applications/web_app_database.cc

@@ -53,7 +53,7 @@ void WebAppDatabase::Write(
     std::unique_ptr<syncer::MetadataChangeList> metadata_change_list,
     CompletionCallback callback) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  DCHECK(opened_);
+  CHECK(opened_);
 
   std::unique_ptr<syncer::ModelTypeStore::WriteBatch> write_batch =
       store_->CreateWriteBatch();

chrome/browser/web_applications/web_app_database.h

@@ -59,6 +59,8 @@ class WebAppDatabase {
   static std::unique_ptr<WebApp> ParseWebApp(const AppId& app_id,
                                              const std::string& value);
 
+  bool is_opened() const { return opened_; }
+
  private:
   static std::unique_ptr<WebApp> CreateWebApp(const WebAppProto& local_data);
 

chrome/browser/web_applications/web_app_sync_bridge.cc

@@ -129,8 +129,11 @@ WebAppSyncBridge::WebAppSyncBridge(
 WebAppSyncBridge::~WebAppSyncBridge() = default;
 
 std::unique_ptr<WebAppRegistryUpdate> WebAppSyncBridge::BeginUpdate() {
+  DCHECK(database_->is_opened());
+
   DCHECK(!is_in_update_);
   is_in_update_ = true;
+
   return std::make_unique<WebAppRegistryUpdate>(
       registrar_, util::PassKey<WebAppSyncBridge>());
 }