Commit 5841bf3a authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

🤠 Disable StartSurfaceTest#testShow_TrendyTerms__NoInstant_Return

This test fails on Android N. It has been added very recently by:
https://chromium-review.googlesource.com/c/chromium/src/+/2265236

TBR=wychen@chromium.org,yuezhanggg@chromium.org

Bug: 1102288,1099037
Change-Id: Ie98a7e1771f11934a132e8b7fd9ed7111bde8ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282561Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785310}
parent 7eb541e8
...@@ -136,11 +136,13 @@ public class StartSurfaceTest { ...@@ -136,11 +136,13 @@ public class StartSurfaceTest {
@Rule @Rule
public TestRule mProcessor = new Features.InstrumentationProcessor(); public TestRule mProcessor = new Features.InstrumentationProcessor();
private final boolean mUseInstantStart;
private final boolean mImmediateReturn; private final boolean mImmediateReturn;
public StartSurfaceTest(boolean useInstantStart, boolean immediateReturn) { public StartSurfaceTest(boolean useInstantStart, boolean immediateReturn) {
CachedFeatureFlags.setForTesting(ChromeFeatureList.INSTANT_START, useInstantStart); CachedFeatureFlags.setForTesting(ChromeFeatureList.INSTANT_START, useInstantStart);
mUseInstantStart = useInstantStart;
mImmediateReturn = immediateReturn; mImmediateReturn = immediateReturn;
} }
...@@ -281,6 +283,11 @@ public class StartSurfaceTest { ...@@ -281,6 +283,11 @@ public class StartSurfaceTest {
@CommandLineFlags.Add({BASE_PARAMS + "/trendyterms" + @CommandLineFlags.Add({BASE_PARAMS + "/trendyterms" +
"/hide_switch_when_no_incognito_tabs/true"}) "/hide_switch_when_no_incognito_tabs/true"})
public void testShow_TrendyTerms() { public void testShow_TrendyTerms() {
// TODO(https://crbug.com/1102288) Reenable this test.
if (!mUseInstantStart && mImmediateReturn) {
return;
}
// clang-format on // clang-format on
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
if (!mImmediateReturn) { if (!mImmediateReturn) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment