Commit 5879bb51 authored by Boris Sazonov's avatar Boris Sazonov Committed by Commit Bot

[Unity][Android] Use wrap_content for TextViews in SigninView

This CL changes the layout for account picker in signin_view.xml so it
uses wrap_content for layout_height instead of explicit height in dps.
This is a follow-up to https://crrev.com/c/986262 that has done the same
for the account row in the account picker dialog.
Using explicit height for TextViews is dangerous as it may cause
clipping when font scaling is enabled, especially with tall scripts.
This CL also fixes ordering of XMLs attributes in the chunk it changes.

Bug: 814728
Change-Id: Ie7d1c7c9ccc8eb56bff3653c06aedff39cd50bc3
Reviewed-on: https://chromium-review.googlesource.com/999593Reviewed-by: default avatarBernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548752}
parent 3007e94b
...@@ -59,26 +59,29 @@ ...@@ -59,26 +59,29 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:layout_alignParentStart="true" android:layout_alignParentStart="true"
android:layout_centerVertical="true"
android:layout_marginEnd="16dp" android:layout_marginEnd="16dp"
android:contentDescription="@null" android:contentDescription="@null"
tools:src="@drawable/logo_avatar_anonymous"/> tools:src="@drawable/logo_avatar_anonymous"/>
<TextView <TextView
android:id="@+id/account_name" android:id="@+id/account_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="20dp" android:layout_height="wrap_content"
android:layout_toEndOf="@id/account_image"
android:layout_toStartOf="@id/expand_icon" android:layout_toStartOf="@id/expand_icon"
android:layout_toEndOf="@id/account_image"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="20dp"
android:textAppearance="@style/BlackBodyDefault" android:textAppearance="@style/BlackBodyDefault"
tools:text="John Doe"/> tools:text="John Doe"/>
<TextView <TextView
android:id="@+id/account_email" android:id="@+id/account_email"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="20dp" android:layout_height="wrap_content"
android:layout_below="@id/account_name" android:layout_below="@id/account_name"
android:layout_toEndOf="@id/account_image"
android:layout_toStartOf="@id/expand_icon" android:layout_toStartOf="@id/expand_icon"
android:layout_toEndOf="@id/account_image"
android:gravity="center_vertical" android:gravity="center_vertical"
android:minHeight="20dp"
android:textAppearance="@style/BlackCaption" android:textAppearance="@style/BlackCaption"
tools:text="john.doe@example.com"/> tools:text="john.doe@example.com"/>
<ImageView <ImageView
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment