Commit 58908161 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove direct uses of TestingFunctionFactory

Replace them with uses of TestingFactory which is based
on base::Callback<> instead of function pointers.

This converts uses in /chrome/browser/extensions/api/mdns.

This CL was uploaded by git cl split.

TBR=vitalybuka@chromium.org

Bug: 809610
Change-Id: I8796684bd7f2948bcf7463a804698aa148a2cfcb
Reviewed-on: https://chromium-review.googlesource.com/c/1246171Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarVitaly Buka <vitalybuka@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596191}
parent 6dc56841
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include <utility> #include <utility>
#include <vector> #include <vector>
#include "base/bind.h"
#include "base/values.h" #include "base/values.h"
#include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h" #include "chrome/browser/extensions/extension_service_test_base.h"
...@@ -198,9 +199,8 @@ class MDnsAPITest : public extensions::ExtensionServiceTestBase { ...@@ -198,9 +199,8 @@ class MDnsAPITest : public extensions::ExtensionServiceTestBase {
} }
// Returns the mDNS API factory function (mock vs. real) to use for the test. // Returns the mDNS API factory function (mock vs. real) to use for the test.
virtual BrowserContextKeyedServiceFactory::TestingFactoryFunction virtual BrowserContextKeyedServiceFactory::TestingFactory GetMDnsFactory() {
GetMDnsFactory() { return base::BindRepeating(&MDnsAPITestingFactoryFunction);
return MDnsAPITestingFactoryFunction;
} }
void TearDown() override { void TearDown() override {
...@@ -257,9 +257,8 @@ class MDnsAPIMaxServicesTest : public MDnsAPITest { ...@@ -257,9 +257,8 @@ class MDnsAPIMaxServicesTest : public MDnsAPITest {
class MDnsAPIDiscoveryTest : public MDnsAPITest { class MDnsAPIDiscoveryTest : public MDnsAPITest {
public: public:
BrowserContextKeyedServiceFactory::TestingFactoryFunction GetMDnsFactory() BrowserContextKeyedServiceFactory::TestingFactory GetMDnsFactory() override {
override { return base::BindRepeating(&MockedMDnsAPITestingFactoryFunction);
return MockedMDnsAPITestingFactoryFunction;
} }
void SetUp() override { void SetUp() override {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment