Commit 596e3dbd authored by chrishenry@google.com's avatar chrishenry@google.com

Delete now unused PageMeasurement class.

BUG=383635

Review URL: https://codereview.chromium.org/498563002

Cr-Commit-Position: refs/heads/master@{#291355}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291355 0039d316-1c4b-4281-b951-d872f2087c98
parent 9fcc6867
...@@ -6,7 +6,7 @@ class Metric(object): ...@@ -6,7 +6,7 @@ class Metric(object):
"""Base class for all the metrics that are used by telemetry measurements. """Base class for all the metrics that are used by telemetry measurements.
The Metric class represents a way of measuring something. Metrics are The Metric class represents a way of measuring something. Metrics are
helper classes used by PageMeasurements. Each PageMeasurement may use helper classes used by PageTests. Each PageTest may use
multiple metrics; each metric should be focussed on collecting data multiple metrics; each metric should be focussed on collecting data
about one thing. about one thing.
""" """
...@@ -35,7 +35,7 @@ class Metric(object): ...@@ -35,7 +35,7 @@ class Metric(object):
"""Add the data collected into the results object for a measurement. """Add the data collected into the results object for a measurement.
Metrics may implement AddResults to provide a common way to add results Metrics may implement AddResults to provide a common way to add results
to the PageTestResults in PageMeasurement.AddMeasurement -- to the PageTestResults in PageTest.ValidateOrMeasurePage --
results should be added with results.AddValue(...). results should be added with results.AddValue(...).
""" """
raise NotImplementedError() raise NotImplementedError()
...@@ -148,7 +148,7 @@ def AddResultsForProcesses(results, memory_stats, chart_trace_name='final', ...@@ -148,7 +148,7 @@ def AddResultsForProcesses(results, memory_stats, chart_trace_name='final',
"""Adds memory stats for browser, renderer and gpu processes. """Adds memory stats for browser, renderer and gpu processes.
Args: Args:
results: A PageMeasurement results object. results: A telemetry.results.PageTestResults object.
memory_stats: System memory stats collected. memory_stats: System memory stats collected.
chart_trace_name: Trace to identify memory metrics. Default is 'final'. chart_trace_name: Trace to identify memory metrics. Default is 'final'.
metric_trace_name: Trace to identify the metric results per test page. metric_trace_name: Trace to identify the metric results per test page.
......
...@@ -32,7 +32,7 @@ class SpeedIndexMetric(Metric): ...@@ -32,7 +32,7 @@ class SpeedIndexMetric(Metric):
"""Start recording events. """Start recording events.
This method should be called in the WillNavigateToPage method of This method should be called in the WillNavigateToPage method of
a PageMeasurement, so that all the events can be captured. If it's called a PageTest, so that all the events can be captured. If it's called
in DidNavigateToPage, that will be too late. in DidNavigateToPage, that will be too late.
""" """
self._impl = (VideoSpeedIndexImpl() if tab.video_capture_supported else self._impl = (VideoSpeedIndexImpl() if tab.video_capture_supported else
......
# Copyright 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from telemetry.page import page_test
class PageMeasurement(page_test.PageTest):
"""DEPRECATED: Please extend page_test.PageTest directly."""
def __init__(self,
action_name_to_run='',
needs_browser_restart_after_each_page=False,
discard_first_result=False,
clear_cache_before_each_run=False,
is_action_name_to_run_optional=False):
super(PageMeasurement, self).__init__(
action_name_to_run,
needs_browser_restart_after_each_page,
discard_first_result,
clear_cache_before_each_run,
is_action_name_to_run_optional=is_action_name_to_run_optional)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment