Commit 597be546 authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

Disable ASAN heap corruption unittests.

The ASAN runtime doesn't detect heap corruption from uninstrumented code,
and so the test fails to die.

Bug: 818747,827548
Change-Id: Ic8bd73c375887b3cf1de79b6fe5838cd31efa426
Reviewed-on: https://chromium-review.googlesource.com/992572
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548074}
parent c4b7762b
...@@ -221,11 +221,13 @@ TEST(ToolsSanityTest, AsanHeapUseAfterFree) { ...@@ -221,11 +221,13 @@ TEST(ToolsSanityTest, AsanHeapUseAfterFree) {
} }
#if defined(OS_WIN) #if defined(OS_WIN)
TEST(ToolsSanityTest, AsanCorruptHeapBlock) { // The ASAN runtime doesn't detect heap corruption, this needs fixing before
// ASAN builds can ship to the wild. See https://crbug.com/818747.
TEST(ToolsSanityTest, DISABLED_AsanCorruptHeapBlock) {
HARMFUL_ACCESS(debug::AsanCorruptHeapBlock(), ""); HARMFUL_ACCESS(debug::AsanCorruptHeapBlock(), "");
} }
TEST(ToolsSanityTest, AsanCorruptHeap) { TEST(ToolsSanityTest, DISABLED_AsanCorruptHeap) {
// This test will kill the process by raising an exception, there's no // This test will kill the process by raising an exception, there's no
// particular string to look for in the stack trace. // particular string to look for in the stack trace.
EXPECT_DEATH(debug::AsanCorruptHeap(), ""); EXPECT_DEATH(debug::AsanCorruptHeap(), "");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment