Commit 5a0107a2 authored by xiyuan's avatar xiyuan Committed by Commit bot

cros: Fix WebviewLoginTest.Basic multiple login attempts.

ShowSigninScreenForCreds is used to automatically fill-in sign-in
forms and submit it. WebviewLoginTest.Basic does that manually
thus should not call it. Otherwise, /_/embedded/signin/challenge
is called multiple times with wrong email (empty) and could trigger
FakeGaia failures.

BUG=472095

Review URL: https://codereview.chromium.org/1069423004

Cr-Commit-Position: refs/heads/master@{#324353}
parent c2bd1aa6
...@@ -46,8 +46,6 @@ class WebviewLoginTest : public OobeBaseTest { ...@@ -46,8 +46,6 @@ class WebviewLoginTest : public OobeBaseTest {
"});")); "});"));
content::DOMMessageQueue message_queue; content::DOMMessageQueue message_queue;
GetLoginDisplay()->ShowSigninScreenForCreds("", "");
std::string message; std::string message;
ASSERT_TRUE(message_queue.WaitForMessage(&message)); ASSERT_TRUE(message_queue.WaitForMessage(&message));
EXPECT_EQ("\"GaiaReady\"", message); EXPECT_EQ("\"GaiaReady\"", message);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment