Commit 5a6bb449 authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

NearbyShare: Add aria labels to NearbyPageTemplate buttons

Add aria-labels to buttons for improved a11y experience with
NearbyShare onboarding page.

Bug: 1148456
Test: Local
Change-Id: I706d9c28c0947ff40432f4c932846a1748224193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545194Reviewed-by: default avatarJames Vecore <vecore@google.com>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828600}
parent 15b9c735
...@@ -53,7 +53,8 @@ ...@@ -53,7 +53,8 @@
cancel-button-event-name="close"> cancel-button-event-name="close">
<div id=center-content slot="content"> <div id=center-content slot="content">
<iron-icon id="splash-image-column" <iron-icon id="splash-image-column"
icon="nearby-images:nearby-onboarding-splash"> icon="nearby-images:nearby-onboarding-splash"
aria-hidden="true">
</iron-icon> </iron-icon>
<div id="device-name-column"> <div id="device-name-column">
<cr-input label="$i18n{nearbyShareOnboardingPageDeviceName}" <cr-input label="$i18n{nearbyShareOnboardingPageDeviceName}"
......
...@@ -63,19 +63,20 @@ ...@@ -63,19 +63,20 @@
<div id="actions"> <div id="actions">
<template is="dom-if" if="[[utilityButtonLabel]]"> <template is="dom-if" if="[[utilityButtonLabel]]">
<cr-button id="utilityButton" class="cancel-button" <cr-button id="utilityButton" class="cancel-button"
on-click="onUtilityClick_"> on-click="onUtilityClick_" aria-label="[[utilityButtonLabel]]">
[[utilityButtonLabel]] [[utilityButtonLabel]]
</cr-button> </cr-button>
</template> </template>
<template is="dom-if" if="[[cancelButtonLabel]]"> <template is="dom-if" if="[[cancelButtonLabel]]">
<cr-button id="cancelButton" class="cancel-button" <cr-button id="cancelButton" class="cancel-button"
on-click="onCancelClick_"> on-click="onCancelClick_" aria-label="[[cancelButtonLabel]]">
[[cancelButtonLabel]] [[cancelButtonLabel]]
</cr-button> </cr-button>
</template> </template>
<template is="dom-if" if="[[actionButtonLabel]]"> <template is="dom-if" if="[[actionButtonLabel]]">
<cr-button id="actionButton" class="action-button" <cr-button id="actionButton" class="action-button"
on-click="onActionClick_" disabled="[[actionDisabled]]"> on-click="onActionClick_" disabled="[[actionDisabled]]"
aria-label="[[actionButtonLabel]]">
[[actionButtonLabel]] [[actionButtonLabel]]
</cr-button> </cr-button>
</template> </template>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment