Change Dactyloscoper::RecordDirectSurface to take arguments by const reference

Change-Id: Idd9f8996b430df63f44273c07e6a4ad993aad38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359558Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/master@{#799415}

third_party/blink/renderer/core/frame/dactyloscoper.cc

@@ -36,7 +36,7 @@ void Dactyloscoper::Record(ExecutionContext* context, WebFeature feature) {
 // static
 void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
                                         WebFeature feature,
-                                        IdentifiableToken value) {
+                                        const IdentifiableToken& value) {
   if (!IdentifiabilityStudySettings::Get()->IsActive() || !context)
     return;
   auto* window = DynamicTo<LocalDOMWindow>(context);
@@ -51,7 +51,7 @@ void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
 // static
 void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
                                         WebFeature feature,
-                                        String str) {
+                                        const String& str) {
   if (!IdentifiabilityStudySettings::Get()->IsActive() || !context)
     return;
   if (str.IsEmpty())
@@ -63,7 +63,7 @@ void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
 // static
 void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
                                         WebFeature feature,
-                                        Vector<String> strs) {
+                                        const Vector<String>& strs) {
   if (!IdentifiabilityStudySettings::Get()->IsActive() || !context)
     return;
   if (strs.IsEmpty())
@@ -76,9 +76,10 @@ void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
 }
 
 // static
-void Dactyloscoper::RecordDirectSurface(ExecutionContext* context,
+void Dactyloscoper::RecordDirectSurface(
+    ExecutionContext* context,
     WebFeature feature,
-                                        NotShared<DOMFloat32Array> buffer) {
+    const NotShared<DOMFloat32Array>& buffer) {
   if (!IdentifiabilityStudySettings::Get()->IsActive() || !context)
     return;
   if (buffer.IsNull() || buffer->lengthAsSizeT() == 0)

third_party/blink/renderer/core/frame/dactyloscoper.h

@@ -35,14 +35,14 @@ class CORE_EXPORT Dactyloscoper {
   // methods with HighEntropy=Direct.
   static void RecordDirectSurface(ExecutionContext*,
                                   WebFeature,
-                                  IdentifiableToken);
-  static void RecordDirectSurface(ExecutionContext*, WebFeature, String);
+                                  const IdentifiableToken&);
+  static void RecordDirectSurface(ExecutionContext*, WebFeature, const String&);
   static void RecordDirectSurface(ExecutionContext*,
                                   WebFeature,
-                                  Vector<String>);
+                                  const Vector<String>&);
   static void RecordDirectSurface(ExecutionContext*,
                                   WebFeature,
-                                  NotShared<DOMFloat32Array>);
+                                  const NotShared<DOMFloat32Array>&);
   static void RecordDirectSurface(ExecutionContext*,
                                   WebFeature,
                                   SVGStringListTearOff*);