Commit 5b377bd0 authored by Jan Scheffler's avatar Jan Scheffler Committed by Commit Bot

[DevTools] Reenable test for Network Panel changes

This cl updates the test results for crrev.com/c/19671359.
Cl disabling the test: crrev.com/c/1985772.

Bug: chromium:1019723
Change-Id: I82ef805dc837e2c3b91dafc5709366da0d8bdb04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985775
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728179}
parent 79b637e4
...@@ -6078,7 +6078,6 @@ crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [ ...@@ -6078,7 +6078,6 @@ crbug.com/1029489 http/tests/devtools/elements/elements-linkify-attributes.js [
crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ] crbug.com/1029826 http/tests/devtools/copy-network-request.js [ Pass Failure ]
crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ] crbug.com/1029521 virtual/threaded/external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html [ Pass Failure Timeout ]
crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ] crbug.com/1030258 http/tests/devtools/network/network-cookies-pane.js [ Pass Failure ]
crbug.com/1019723 http/tests/devtools/network/waterfall-header-height-updates.js [ Pass Failure ]
# Enable scroll-snap tests on impl thread # Enable scroll-snap tests on impl thread
# These are currently failing on Mac which needs more investigation, snap-scrolls-visual-viewport seems flaky # These are currently failing on Mac which needs more investigation, snap-scrolls-visual-viewport seems flaky
......
...@@ -22,13 +22,16 @@ ...@@ -22,13 +22,16 @@
TestRunner.addResult('Node rendered showing fetch resource'); TestRunner.addResult('Node rendered showing fetch resource');
UI.panels.network._onRequestSelected({data: request}); UI.panels.network._onRequestSelected({data: request});
UI.panels.network._showRequestPanel(); UI.panels.network._showRequestPanel();
// Wait for NetworkLogViewColumn._updateRowsSize to update the header height
await new Promise(window.requestAnimationFrame);
TestRunner.addResult('Height of waterfall header: ' + NetworkTestRunner.networkWaterfallColumn()._headerHeight); TestRunner.addResult('Height of waterfall header: ' + NetworkTestRunner.networkWaterfallColumn()._headerHeight);
TestRunner.addResult('Setting large row setting to true'); TestRunner.addResult('Setting large row setting to true');
UI.panels.network._networkLogLargeRowsSetting.set(true); UI.panels.network._networkLogLargeRowsSetting.set(true);
TestRunner.addResult('Unselecting request from grid'); TestRunner.addResult('Unselecting request from grid');
UI.panels.network._hideRequestPanel(); UI.panels.network._hideRequestPanel();
// Wait for NetworkLogViewColumn._updateRowsSize to update the header height
await new Promise(window.requestAnimationFrame);
TestRunner.addResult('Height of waterfall header: ' + NetworkTestRunner.networkWaterfallColumn()._headerHeight); TestRunner.addResult('Height of waterfall header: ' + NetworkTestRunner.networkWaterfallColumn()._headerHeight);
TestRunner.completeTest(); TestRunner.completeTest();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment