Commit 5c43f5fe authored by Livvie Lin's avatar Livvie Lin Committed by Commit Bot

Rebaseline DevTools security-state-comparator web test

After adding insecure-broken to the DevTools protocol, the
SecurityStateComparator needed to be updated to handle the additional
value. This cl rebaselines and re-enables the test now that the frontend
changes have been submitted (crrrev.com/c/1880092).

Bug: 1008218
Change-Id: Iae4cfa2dd43142ffea695737320cf3dd52aa9692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884353Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710369}
parent 881825a2
...@@ -5751,9 +5751,6 @@ crbug.com/1016804 external/wpt/css/css-grid/layout-algorithm/grid-flex-track-int ...@@ -5751,9 +5751,6 @@ crbug.com/1016804 external/wpt/css/css-grid/layout-algorithm/grid-flex-track-int
crbug.com/1017626 [ Linux ] external/wpt/compat/idlharness.window.html [ Pass Timeout ] crbug.com/1017626 [ Linux ] external/wpt/compat/idlharness.window.html [ Pass Timeout ]
crbug.com/925325 [ Win ] storage/indexeddb/index-population.html [ Pass Timeout ] crbug.com/925325 [ Win ] storage/indexeddb/index-population.html [ Pass Timeout ]
# DevTools Security Panel (disabled temporarily as part of workflow)
crbug.com/1008218 http/tests/devtools/security/security-state-comparator.js [ Failure ]
# Sheriff 2019-10-25 # Sheriff 2019-10-25
crbug.com/1018027 virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-to-unregistered.html [ Pass Crash ] crbug.com/1018027 virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-to-unregistered.html [ Pass Crash ]
crbug.com/1018027 virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-fallback.html [ Pass Crash ] crbug.com/1018027 virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-fallback.html [ Pass Crash ]
......
Tests that SecurityStateComparator correctly compares the severity of security states. Tests that SecurityStateComparator correctly compares the severity of security states.
Sign of SecurityStateComparator("info","info"): 0 (expected: 0) Sign of SecurityStateComparator("info","info"): 0 (expected: 0)
Sign of SecurityStateComparator("info","insecure-broken"): -1 (expected: -1)
Sign of SecurityStateComparator("info","insecure"): -1 (expected: -1) Sign of SecurityStateComparator("info","insecure"): -1 (expected: -1)
Sign of SecurityStateComparator("info","neutral"): -1 (expected: -1) Sign of SecurityStateComparator("info","neutral"): -1 (expected: -1)
Sign of SecurityStateComparator("info","secure"): -1 (expected: -1) Sign of SecurityStateComparator("info","secure"): -1 (expected: -1)
Sign of SecurityStateComparator("info","unknown"): -1 (expected: -1) Sign of SecurityStateComparator("info","unknown"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure-broken","info"): 1 (expected: 1)
Sign of SecurityStateComparator("insecure-broken","insecure-broken"): 0 (expected: 0)
Sign of SecurityStateComparator("insecure-broken","insecure"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure-broken","neutral"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure-broken","secure"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure-broken","unknown"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure","info"): 1 (expected: 1) Sign of SecurityStateComparator("insecure","info"): 1 (expected: 1)
Sign of SecurityStateComparator("insecure","insecure-broken"): 1 (expected: 1)
Sign of SecurityStateComparator("insecure","insecure"): 0 (expected: 0) Sign of SecurityStateComparator("insecure","insecure"): 0 (expected: 0)
Sign of SecurityStateComparator("insecure","neutral"): -1 (expected: -1) Sign of SecurityStateComparator("insecure","neutral"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure","secure"): -1 (expected: -1) Sign of SecurityStateComparator("insecure","secure"): -1 (expected: -1)
Sign of SecurityStateComparator("insecure","unknown"): -1 (expected: -1) Sign of SecurityStateComparator("insecure","unknown"): -1 (expected: -1)
Sign of SecurityStateComparator("neutral","info"): 1 (expected: 1) Sign of SecurityStateComparator("neutral","info"): 1 (expected: 1)
Sign of SecurityStateComparator("neutral","insecure-broken"): 1 (expected: 1)
Sign of SecurityStateComparator("neutral","insecure"): 1 (expected: 1) Sign of SecurityStateComparator("neutral","insecure"): 1 (expected: 1)
Sign of SecurityStateComparator("neutral","neutral"): 0 (expected: 0) Sign of SecurityStateComparator("neutral","neutral"): 0 (expected: 0)
Sign of SecurityStateComparator("neutral","secure"): -1 (expected: -1) Sign of SecurityStateComparator("neutral","secure"): -1 (expected: -1)
Sign of SecurityStateComparator("neutral","unknown"): -1 (expected: -1) Sign of SecurityStateComparator("neutral","unknown"): -1 (expected: -1)
Sign of SecurityStateComparator("secure","info"): 1 (expected: 1) Sign of SecurityStateComparator("secure","info"): 1 (expected: 1)
Sign of SecurityStateComparator("secure","insecure-broken"): 1 (expected: 1)
Sign of SecurityStateComparator("secure","insecure"): 1 (expected: 1) Sign of SecurityStateComparator("secure","insecure"): 1 (expected: 1)
Sign of SecurityStateComparator("secure","neutral"): 1 (expected: 1) Sign of SecurityStateComparator("secure","neutral"): 1 (expected: 1)
Sign of SecurityStateComparator("secure","secure"): 0 (expected: 0) Sign of SecurityStateComparator("secure","secure"): 0 (expected: 0)
Sign of SecurityStateComparator("secure","unknown"): -1 (expected: -1) Sign of SecurityStateComparator("secure","unknown"): -1 (expected: -1)
Sign of SecurityStateComparator("unknown","info"): 1 (expected: 1) Sign of SecurityStateComparator("unknown","info"): 1 (expected: 1)
Sign of SecurityStateComparator("unknown","insecure-broken"): 1 (expected: 1)
Sign of SecurityStateComparator("unknown","insecure"): 1 (expected: 1) Sign of SecurityStateComparator("unknown","insecure"): 1 (expected: 1)
Sign of SecurityStateComparator("unknown","neutral"): 1 (expected: 1) Sign of SecurityStateComparator("unknown","neutral"): 1 (expected: 1)
Sign of SecurityStateComparator("unknown","secure"): 1 (expected: 1) Sign of SecurityStateComparator("unknown","secure"): 1 (expected: 1)
......
...@@ -8,9 +8,9 @@ ...@@ -8,9 +8,9 @@
await TestRunner.showPanel('security'); await TestRunner.showPanel('security');
var ordering = [ var ordering = [
Protocol.Security.SecurityState.Info, Protocol.Security.SecurityState.Insecure, Protocol.Security.SecurityState.Info, Protocol.Security.SecurityState.InsecureBroken,
Protocol.Security.SecurityState.Neutral, Protocol.Security.SecurityState.Secure, Protocol.Security.SecurityState.Insecure, Protocol.Security.SecurityState.Neutral,
Protocol.Security.SecurityState.Unknown Protocol.Security.SecurityState.Secure, Protocol.Security.SecurityState.Unknown
]; ];
TestRunner.assertEquals(ordering.length, Object.keys(Protocol.Security.SecurityState).length); TestRunner.assertEquals(ordering.length, Object.keys(Protocol.Security.SecurityState).length);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment