Commit 5c82d6f1 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable Window Open API test.

This test was disabled on Linux, Windows, and Mac debug. It
passed 3000 iterations on Linux and Windows, and 600 iterations
on Mac debug without flakes.

Bug: 253417
Change-Id: Id71ceac3a8b5ae43145f93935b92851fbe8d04e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255661Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784492}
parent 99dbe47a
...@@ -2,21 +2,15 @@ ...@@ -2,21 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "base/command_line.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/extensions/extension_apitest.h"
#include "content/public/test/browser_test.h" #include "content/public/test/browser_test.h"
#include "extensions/test/result_catcher.h" #include "extensions/test/result_catcher.h"
namespace extensions { namespace extensions {
// http://crbug.com/253417 for NDEBUG
#if (defined(OS_WIN) || defined(OS_MACOSX)) && defined(NDEBUG)
// Focus test fails if there is no window manager on Linux.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenFocus) { IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenFocus) {
ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_; ASSERT_TRUE(RunExtensionTest("window_open/focus")) << message_;
} }
#endif
// The test uses the chrome.browserAction.openPopup API, which requires that the // The test uses the chrome.browserAction.openPopup API, which requires that the
// window can automatically be activated. // window can automatically be activated.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment