Commit 5cbb6720 authored by Ned Nguyen's avatar Ned Nguyen Committed by Commit Bot

Move the note about using NOTRY=true for disabling CL to the top of Telemetry disabling section

Change-Id: I9198c35c130fd59c8e1f1674e9e428edd066413d
Reviewed-on: https://chromium-review.googlesource.com/848074Reviewed-by: default avatarCharlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526700}
parent 0f81f7e6
......@@ -335,6 +335,12 @@ If a telemetry test is failing and there is no clear culprit to revert
immediately, disable the story on the failing platforms.
You can do this with [Expectations](https://cs.chromium.org/chromium/src/tools/perf/expectations.config).
Disabling CLs can be TBR-ed to anyone in
[tools/perf/OWNERS](https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/OWNERS).
As long as the disabling CL touches only tools/perf/expectations.config, you can
use TBR and NOTRY=true to submit the CL immediately.
An expectation is a line in the expectations file in the following format:
```
reason [ conditions ] benchmark/story [ Skip ]
......@@ -385,10 +391,6 @@ of this format:
crbug.com/123456 [ CONDITIONS ] memory_benchmark/* [ Skip ]
```
Disabling CLs can be TBR-ed to anyone in [tools/perf/OWNERS](https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/OWNERS),
As long as a disabling CL touches only tools/perf/expectations.config, you can
use TBR and NOTRY=true to submit the CL immediately.
### Disabling Other Tests
Non-telemetry tests are configured in [chromium.perf.json](https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json) **But do not manually edit this file.**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment