bindings: Generate entries for .cpp/.h files from IDL dictionaries in GN
By auto-generating those entries, we can stop requiring people to manually update lists such as |generated_core_dictionary_files| every time Blink's lists of IDL dictionary files change. Since the names of the generated .cpp/.h follow a fixed, specific format that only depends on their respective IDL file's path and file name, we can use GN itself to do some path introspection and generate the file names we want in idl_impl(). While here, change the names of idl_impl()'s required arguments to make their purpose more explicit: it is not immediately obvious that we differentiate unions and callback functions from dictionary files in terms of where the latter are generated and their file names, as well as why idl_impl() only expects non-dictionary files in its outputs list. A good next step would be generating dictionary impl files separately from unions and callbacks to avoid the confusion altogether. Bug: 725996 Change-Id: I41b06e8d71f33b21d77944216fcb07d0557ac47b Reviewed-on: https://chromium-review.googlesource.com/517795 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#476262}
Showing
Please register or sign in to comment