Commit 5d6c8f71 authored by Hazem Ashmawy's avatar Hazem Ashmawy Committed by Commit Bot

[AW] Add a comment to why default channel crashes are sampled out

This comment was dropped when moving crash reports sampling from crashpad to upload service. It provides more context why we sample crashes for default channel (debug/unknown channel).

Bug: N/A
Change-Id: I1d949aafdd59541b9f61fdc23885481f46c16322
Test: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075117
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744682}
parent 04bb1146
...@@ -83,6 +83,7 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate { ...@@ -83,6 +83,7 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
return new CrashReportingPermissionManager() { return new CrashReportingPermissionManager() {
@Override @Override
public boolean isClientInMetricsSample() { public boolean isClientInMetricsSample() {
// Downsample unknown channel as a precaution in case it ends up being shipped.
if (mSamplingDelegate.getChannel() == Channel.STABLE if (mSamplingDelegate.getChannel() == Channel.STABLE
|| mSamplingDelegate.getChannel() == Channel.DEFAULT) { || mSamplingDelegate.getChannel() == Channel.DEFAULT) {
return mSamplingDelegate.getRandomSample() < CRASH_DUMP_PERCENTAGE_FOR_STABLE; return mSamplingDelegate.getRandomSample() < CRASH_DUMP_PERCENTAGE_FOR_STABLE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment