Commit 5e5b7ae4 authored by Anthony Cui's avatar Anthony Cui Committed by Commit Bot

Allow manual translation on pages with page level notranslate meta tag

Bug: 1151492
Change-Id: I8e205b8eb39fb7ce54cec9373834980344252f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556658Reviewed-by: default avatarMegan Jablonski <megjablon@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830595}
parent 915ce49e
...@@ -242,8 +242,7 @@ bool TranslateManager::CanManuallyTranslate(bool menuLogging) { ...@@ -242,8 +242,7 @@ bool TranslateManager::CanManuallyTranslate(bool menuLogging) {
} }
if (!translate_client_->IsTranslatableURL( if (!translate_client_->IsTranslatableURL(
translate_driver_->GetVisibleURL()) || translate_driver_->GetVisibleURL())) {
!language_state_.page_needs_translation()) {
if (!menuLogging) if (!menuLogging)
return false; return false;
TranslateBrowserMetrics::ReportMenuTranslationUnavailableReason( TranslateBrowserMetrics::ReportMenuTranslationUnavailableReason(
......
...@@ -1003,8 +1003,10 @@ TEST_F(TranslateManagerTest, CanManuallyTranslate_PageNeedsTranslation) { ...@@ -1003,8 +1003,10 @@ TEST_F(TranslateManagerTest, CanManuallyTranslate_PageNeedsTranslation) {
network_notifier_.SimulateOnline(); network_notifier_.SimulateOnline();
translate_manager_->GetLanguageState()->LanguageDetermined("de", false); translate_manager_->GetLanguageState()->LanguageDetermined("de", false);
EXPECT_FALSE(translate_manager_->CanManuallyTranslate()); // Users should be able to manually translate the page, even when
EXPECT_FALSE(translate_manager_->CanManuallyTranslate(true)); // |page_needs_translation| is false.
EXPECT_TRUE(translate_manager_->CanManuallyTranslate());
EXPECT_TRUE(translate_manager_->CanManuallyTranslate(true));
translate_manager_->GetLanguageState()->LanguageDetermined("de", true); translate_manager_->GetLanguageState()->LanguageDetermined("de", true);
EXPECT_TRUE(translate_manager_->CanManuallyTranslate()); EXPECT_TRUE(translate_manager_->CanManuallyTranslate());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment