Commit 5f12dda9 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Fix deprecated function use in generated bindings

Use Maybe version of BooleanValue fallback for generated bindings.

Bug: v8:7786
Change-Id: I8cc17d532840caca2354d6a89be5abe952e47c4a
Reviewed-on: https://chromium-review.googlesource.com/1160201Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580137}
parent 9c7439bc
...@@ -192,7 +192,7 @@ void {{v8_class}}::ToImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{ ...@@ -192,7 +192,7 @@ void {{v8_class}}::ToImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{
{# 16. Boolean (fallback) #} {# 16. Boolean (fallback) #}
{% elif boolean_type %} {% elif boolean_type %}
{ {
impl.SetBoolean(v8Value->BooleanValue()); impl.SetBoolean(v8Value->BooleanValue(isolate->GetCurrentContext()).ToChecked());
return; return;
} }
......
...@@ -89,7 +89,7 @@ void V8BooleanOrElementSequence::ToImpl(v8::Isolate* isolate, v8::Local<v8::Valu ...@@ -89,7 +89,7 @@ void V8BooleanOrElementSequence::ToImpl(v8::Isolate* isolate, v8::Local<v8::Valu
} }
{ {
impl.SetBoolean(v8Value->BooleanValue()); impl.SetBoolean(v8Value->BooleanValue(isolate->GetCurrentContext()).ToChecked());
return; return;
} }
} }
......
...@@ -81,7 +81,7 @@ void V8BooleanOrTestCallbackInterface::ToImpl(v8::Isolate* isolate, v8::Local<v8 ...@@ -81,7 +81,7 @@ void V8BooleanOrTestCallbackInterface::ToImpl(v8::Isolate* isolate, v8::Local<v8
} }
{ {
impl.SetBoolean(v8Value->BooleanValue()); impl.SetBoolean(v8Value->BooleanValue(isolate->GetCurrentContext()).ToChecked());
return; return;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment