Commit 5f2e8030 authored by aroben@apple.com's avatar aroben@apple.com

Don't trigger a build when build.webkit.org's HTML files are modified

Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did

Reviewed by Dan Bernstein.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
directories that shouldn't trigger builds. Re-sorted the list.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test to cover the above change.

git-svn-id: svn://svn.chromium.org/blink/trunk@80863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 4482c126
2011-03-11 Adam Roben <aroben@apple.com>
Don't trigger a build when build.webkit.org's HTML files are modified
Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
Reviewed by Dan Bernstein.
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
directories that shouldn't trigger builds. Re-sorted the list.
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test to cover the above change.
2011-03-11 Adam Roben <aroben@apple.com> 2011-03-11 Adam Roben <aroben@apple.com>
Roll out r80848 Roll out r80848
......
...@@ -41,9 +41,10 @@ def _should_file_trigger_build(target_platform, file): ...@@ -41,9 +41,10 @@ def _should_file_trigger_build(target_platform, file):
directories = [ directories = [
# Directories that shouldn't trigger builds on any bots. # Directories that shouldn't trigger builds on any bots.
("Examples", []),
("PerformanceTests", []), ("PerformanceTests", []),
("Source/WebCore/manual-tests", []), ("Source/WebCore/manual-tests", []),
("Examples", []), ("Tools/BuildSlaveSupport/build.webkit.org-config/public_html", []),
("Websites", []), ("Websites", []),
("android", []), ("android", []),
("brew", []), ("brew", []),
...@@ -53,8 +54,8 @@ def _should_file_trigger_build(target_platform, file): ...@@ -53,8 +54,8 @@ def _should_file_trigger_build(target_platform, file):
("opengl", []), ("opengl", []),
("opentype", []), ("opentype", []),
("openvg", []), ("openvg", []),
("wx", []),
("wince", []), ("wince", []),
("wx", []),
# Directories that should trigger builds on only some bots. # Directories that should trigger builds on only some bots.
("Source/JavaScriptGlue", ["mac"]), ("Source/JavaScriptGlue", ["mac"]),
......
...@@ -53,6 +53,7 @@ class ShouldBuildTest(unittest.TestCase): ...@@ -53,6 +53,7 @@ class ShouldBuildTest(unittest.TestCase):
(["Source/WebCore/rendering/RenderThemeMac.mm", "Source/WebCore/rendering/RenderThemeMac.h"], ["mac-leopard", "mac-snowleopard"]), (["Source/WebCore/rendering/RenderThemeMac.mm", "Source/WebCore/rendering/RenderThemeMac.h"], ["mac-leopard", "mac-snowleopard"]),
(["Source/WebCore/rendering/RenderThemeChromiumLinux.h"], ["chromium-linux"]), (["Source/WebCore/rendering/RenderThemeChromiumLinux.h"], ["chromium-linux"]),
(["Source/WebCore/rendering/RenderThemeWinCE.h"], []), (["Source/WebCore/rendering/RenderThemeWinCE.h"], []),
(["Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js"], []),
] ]
def test_should_build(self): def test_should_build(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment