Commit 5f5b8c3d authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Fix use of deprecated ToInt32 v8 method

Since all uses are preceded by IsInt32 checks, it's safe to convert all
these uses to As<v8::Int32> casts.

Bug: v8:7279, v8:8238
Change-Id: I6fadc29adf85294afaa4f7980353ab43add75771
Reviewed-on: https://chromium-review.googlesource.com/c/1349228Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610633}
parent f86778e8
...@@ -511,7 +511,7 @@ void CastStreamingNativeHandler::DestroyCastRtpStream( ...@@ -511,7 +511,7 @@ void CastStreamingNativeHandler::DestroyCastRtpStream(
CHECK_EQ(1, args.Length()); CHECK_EQ(1, args.Length());
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
if (!GetRtpStreamOrThrow(transport_id)) if (!GetRtpStreamOrThrow(transport_id))
return; return;
rtp_stream_map_.erase(transport_id); rtp_stream_map_.erase(transport_id);
...@@ -522,7 +522,7 @@ void CastStreamingNativeHandler::GetSupportedParamsCastRtpStream( ...@@ -522,7 +522,7 @@ void CastStreamingNativeHandler::GetSupportedParamsCastRtpStream(
CHECK_EQ(1, args.Length()); CHECK_EQ(1, args.Length());
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastRtpStream* transport = GetRtpStreamOrThrow(transport_id); CastRtpStream* transport = GetRtpStreamOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
...@@ -548,7 +548,7 @@ void CastStreamingNativeHandler::StartCastRtpStream( ...@@ -548,7 +548,7 @@ void CastStreamingNativeHandler::StartCastRtpStream(
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
CHECK(args[1]->IsObject()); CHECK(args[1]->IsObject());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastRtpStream* transport = GetRtpStreamOrThrow(transport_id); CastRtpStream* transport = GetRtpStreamOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
...@@ -599,7 +599,7 @@ void CastStreamingNativeHandler::StopCastRtpStream( ...@@ -599,7 +599,7 @@ void CastStreamingNativeHandler::StopCastRtpStream(
CHECK_EQ(1, args.Length()); CHECK_EQ(1, args.Length());
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastRtpStream* transport = GetRtpStreamOrThrow(transport_id); CastRtpStream* transport = GetRtpStreamOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
...@@ -611,7 +611,7 @@ void CastStreamingNativeHandler::DestroyCastUdpTransport( ...@@ -611,7 +611,7 @@ void CastStreamingNativeHandler::DestroyCastUdpTransport(
CHECK_EQ(1, args.Length()); CHECK_EQ(1, args.Length());
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
if (!GetUdpTransportOrThrow(transport_id)) if (!GetUdpTransportOrThrow(transport_id))
return; return;
udp_transport_map_.erase(transport_id); udp_transport_map_.erase(transport_id);
...@@ -623,7 +623,7 @@ void CastStreamingNativeHandler::SetDestinationCastUdpTransport( ...@@ -623,7 +623,7 @@ void CastStreamingNativeHandler::SetDestinationCastUdpTransport(
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
CHECK(args[1]->IsObject()); CHECK(args[1]->IsObject());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastUdpTransport* transport = GetUdpTransportOrThrow(transport_id); CastUdpTransport* transport = GetUdpTransportOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
...@@ -647,7 +647,7 @@ void CastStreamingNativeHandler::SetOptionsCastUdpTransport( ...@@ -647,7 +647,7 @@ void CastStreamingNativeHandler::SetOptionsCastUdpTransport(
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
CHECK(args[1]->IsObject()); CHECK(args[1]->IsObject());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastUdpTransport* transport = GetUdpTransportOrThrow(transport_id); CastUdpTransport* transport = GetUdpTransportOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
...@@ -671,7 +671,7 @@ void CastStreamingNativeHandler::ToggleLogging( ...@@ -671,7 +671,7 @@ void CastStreamingNativeHandler::ToggleLogging(
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
CHECK(args[1]->IsBoolean()); CHECK(args[1]->IsBoolean());
const int stream_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int stream_id = args[0].As<v8::Int32>()->Value();
CastRtpStream* stream = GetRtpStreamOrThrow(stream_id); CastRtpStream* stream = GetRtpStreamOrThrow(stream_id);
if (!stream) if (!stream)
return; return;
...@@ -687,7 +687,7 @@ void CastStreamingNativeHandler::GetRawEvents( ...@@ -687,7 +687,7 @@ void CastStreamingNativeHandler::GetRawEvents(
CHECK(args[1]->IsNull() || args[1]->IsString()); CHECK(args[1]->IsNull() || args[1]->IsString());
CHECK(args[2]->IsFunction()); CHECK(args[2]->IsFunction());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
v8::Isolate* isolate = args.GetIsolate(); v8::Isolate* isolate = args.GetIsolate();
v8::Global<v8::Function> callback(isolate, args[2].As<v8::Function>()); v8::Global<v8::Function> callback(isolate, args[2].As<v8::Function>());
std::string extra_data; std::string extra_data;
...@@ -714,7 +714,7 @@ void CastStreamingNativeHandler::GetStats( ...@@ -714,7 +714,7 @@ void CastStreamingNativeHandler::GetStats(
CHECK_EQ(2, args.Length()); CHECK_EQ(2, args.Length());
CHECK(args[0]->IsInt32()); CHECK(args[0]->IsInt32());
CHECK(args[1]->IsFunction()); CHECK(args[1]->IsFunction());
const int transport_id = args[0]->ToInt32(args.GetIsolate())->Value(); const int transport_id = args[0].As<v8::Int32>()->Value();
CastRtpStream* transport = GetRtpStreamOrThrow(transport_id); CastRtpStream* transport = GetRtpStreamOrThrow(transport_id);
if (!transport) if (!transport)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment