Remove EventPath::parent() in favor of NodeRenderingTraversal::parent().

EventPath::parent() is only used in adjusting the result of HitTest in some places.
For example, if a text node is clicked, we have to adjust the result to the *reasonable* parent element of the text node.

In adjusting, we should use NodeRenderingTraversal::parent() instead of EventPath::parent().
That means the adjusted result is no longer shadow roots or insertion points.
The result would be the parent element of the text node in the composed tree.
That should make sense because neither shadow roots nor insertion points are rendered.

BUG=354366

Review URL: https://codereview.chromium.org/210753002

git-svn-id: svn://svn.chromium.org/blink/trunk@169923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt

@@ -5,14 +5,15 @@ Composed Shadow Tree will be:
 DIV	 id=sandbox
 	DIV	 id=top
 		DIV	 id=shadow-host
+			DIV	 id=content-parent
 				#text	
 
 
 Moving mouse from a distributed text node to top
 
   mouseout
-     @content (target: content) (related: top)
-     @shadow-root (target: content) (related: top)
+     @content-parent (target: content-parent) (related: top)
+     @shadow-root (target: content-parent) (related: top)
      @shadow-host (target: shadow-host) (related: top)
      @top (target: shadow-host) (related: top)
 
@@ -20,14 +21,14 @@ Moving mouse from a distributed text node to top
      @top (target: top) (related: shadow-host)
 
   mousewheel
-     @content (target: content)
-     @shadow-root (target: content)
+     @content-parent (target: content-parent)
+     @shadow-root (target: content-parent)
      @shadow-host (target: shadow-host)
      @top (target: shadow-host)
 
   touchstart
-     @content (target: content) (touches: content) (targetTouches: content) (changedTouches: content)
-     @shadow-root (target: content) (touches: content) (targetTouches: content) (changedTouches: content)
+     @content-parent (target: content-parent) (touches: content-parent) (targetTouches: content-parent) (changedTouches: content-parent)
+     @shadow-root (target: content-parent) (touches: content-parent) (targetTouches: content-parent) (changedTouches: content-parent)
      @shadow-host (target: shadow-host) (touches: shadow-host) (targetTouches: shadow-host) (changedTouches: shadow-host)
      @top (target: shadow-host) (touches: shadow-host) (targetTouches: shadow-host) (changedTouches: shadow-host)
 PASS successfullyParsed is true

third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html

@@ -12,14 +12,15 @@
     <script>
         var sandbox = document.getElementById('sandbox');
 
-        // Makes sure an insertion point can receive a event when a distributed text node is clicked.
+        // Makes sure the parent of the insertion point can receive an event when a distributed text node is clicked.
         sandbox.appendChild(
             createDOM('div', {'id': 'top'},
                       createDOM('div', {'id': 'shadow-host'},
                                 createShadowRoot({'id': 'shadow-root'},
-                                                 createDOM('content', {'id': 'content'})),
+                                                 createDOM('div', {'id': 'content-parent'},
+                                                           createDOM('content', {'id': 'content'}))),
                                 document.createTextNode('Text Node'))));
-        addEventListeners(['top', 'shadow-host', 'shadow-host/', 'shadow-host/content']);
+        addEventListeners(['top', 'shadow-host', 'shadow-host/', 'shadow-host/content-parent', 'shadow-host/content']);
         showSandboxTree();
 
         // Calculates the position of the text node.

third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt

@@ -10,7 +10,6 @@ DIV	 id=sandbox
 Moving mouse from a direct child text node of the shadow root to top
 
   mouseout
-     @shadow-root (target: shadow-root) (related: top)
      @shadow-host (target: shadow-host) (related: top)
      @top (target: shadow-host) (related: top)
 
@@ -18,12 +17,10 @@ Moving mouse from a direct child text node of the shadow root to top
      @top (target: top) (related: shadow-host)
 
   touchstart
-     @shadow-root (target: shadow-root) (touches: shadow-root) (targetTouches: shadow-root) (changedTouches: shadow-root)
      @shadow-host (target: shadow-host) (touches: shadow-host) (targetTouches: shadow-host) (changedTouches: shadow-host)
      @top (target: shadow-host) (touches: shadow-host) (targetTouches: shadow-host) (changedTouches: shadow-host)
 
   mousewheel
-     @shadow-root (target: shadow-root)
      @shadow-host (target: shadow-host)
      @top (target: shadow-host)
 PASS successfullyParsed is true

third_party/WebKit/Source/core/events/EventPath.cpp

@@ -45,12 +45,6 @@
 
 namespace WebCore {
 
-Node* EventPath::parent(Node* node)
-{
-    EventPath eventPath(node);
-    return eventPath.size() > 1 ? eventPath[1].node() : 0;
-}
-
 EventTarget* EventPath::eventTargetRespectingTargetRules(Node* referenceNode)
 {
     ASSERT(referenceNode);

third_party/WebKit/Source/core/events/EventPath.h

@@ -63,7 +63,6 @@ public:
     void adjustForRelatedTarget(Node*, EventTarget* relatedTarget);
     void adjustForTouchEvent(Node*, TouchEvent&);
 
-    static Node* parent(Node*);
     static EventTarget* eventTargetRespectingTargetRules(Node*);
 
 private:

third_party/WebKit/Source/core/page/EventHandler.cpp

@@ -699,7 +699,7 @@ bool EventHandler::handleMouseDraggedEvent(const MouseEventWithHitTestResults& e
 
     RenderObject* renderer = targetNode->renderer();
     if (!renderer) {
-        Node* parent = EventPath::parent(targetNode);
+        Node* parent = NodeRenderingTraversal::parent(targetNode);
         if (!parent)
             return false;
 
@@ -1801,7 +1801,7 @@ bool EventHandler::updateDragAndDrop(const PlatformMouseEvent& event, Clipboard*
     // Drag events should never go to text nodes (following IE, and proper mouseover/out dispatch)
     RefPtr<Node> newTarget = mev.targetNode();
     if (newTarget && newTarget->isTextNode())
-        newTarget = EventPath::parent(newTarget.get());
+        newTarget = NodeRenderingTraversal::parent(newTarget.get());
 
     if (AutoscrollController* controller = autoscrollController())
         controller->updateDragAndDrop(newTarget.get(), event.position(), event.timestamp());
@@ -1935,7 +1935,7 @@ void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMo
     else {
         // If the target node is a text node, dispatch on the parent node - rdar://4196646
         if (result && result->isTextNode())
-            result = EventPath::parent(result);
+            result = NodeRenderingTraversal::parent(result);
     }
     m_nodeUnderMouse = result;
     m_instanceUnderMouse = instanceAssociatedWithShadowTreeElement(result);
@@ -2143,7 +2143,7 @@ bool EventHandler::handleWheelEvent(const PlatformWheelEvent& e)
     Node* node = result.innerNode();
     // Wheel events should not dispatch to text nodes.
     if (node && node->isTextNode())
-        node = EventPath::parent(node);
+        node = NodeRenderingTraversal::parent(node);
 
     bool isOverWidget;
     if (e.useLatchedEventNode()) {
@@ -3664,7 +3664,7 @@ bool EventHandler::handleTouchEvent(const PlatformTouchEvent& event)
 
             // Touch events should not go to text nodes
             if (node->isTextNode())
-                node = EventPath::parent(node);
+                node = NodeRenderingTraversal::parent(node);
 
             Document& doc = node->document();
             // Record the originating touch document even if it does not have a touch listener.