Print Preview Componentization: Do not change height in JS

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7089a22f7e9ed0da2a1df1320f0a3d1e511a5c67
Reviewed-on: https://chromium-review.googlesource.com/902793Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534622}

chrome/browser/resources/print_preview/new/destination_dialog.html

@@ -34,9 +34,11 @@
           box-sizing: border-box;
           padding-top: 0;
         }
+        --cr-dialog-wrapper: {
+          max-height: calc(100vh - 40px);
+        }
         box-shadow: 0 4px 23px 5px rgba(0, 0, 0, 0.2),
           0 2px 6px rgba(0, 0, 0, 0.15);
-        height: calc(100% - 40px);
         width: 640px;
       }
 
@@ -45,6 +47,10 @@
         margin-top: 14px;
       }
 
+      :host #lists {
+        height: 100vh;
+      }
+
       :host #dialog .cloudprint-promo {
         align-items: center;
         background-color: #f5f5f5;

chrome/browser/resources/print_preview/new/destination_dialog.js

@@ -62,7 +62,6 @@ Polymer({
         destinationStore,
         print_preview.DestinationStore.EventType.DESTINATION_SEARCH_DONE,
         this.updateDestinations_.bind(this));
-    this.tracker_.add(window, 'resize', this.updateHeight_.bind(this));
   },
 
   /** @private */
@@ -123,20 +122,9 @@ Polymer({
     this.$.dialog.close();
   },
 
-  /** @private */
-  updateHeight_: function() {
-    const heightNum = this.$.dialog.getBoundingClientRect().height -
-        this.$$('.cloudprint-promo').offsetHeight -
-        this.$.buttons.offsetHeight - this.$.titleBox.offsetHeight;
-
-    this.$.lists.style.height = `${heightNum}px`;
-    this.$.lists.style.minHeight = `${heightNum}px`;
-  },
-
   show: function() {
     this.loadingDestinations_ =
         this.destinationStore.isPrintDestinationSearchInProgress;
     this.$.dialog.showModal();
-    this.updateHeight_();
   },
 });

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

@@ -29,6 +29,7 @@
         flex-direction: column;
         max-height: 100vh;
         overflow: auto;
+        @apply(--cr-dialog-wrapper);
       }
 
       /* When needing to flex, force .body-container alone to shrink. */