Make <input type='url'> have UIA LocalizedControlType == 'url'

An <input type='url'> should have LocalizedControlType of "url"
per https://w3c.github.io/html-aam/#el-input-url

Currently its LocalizedControlType is "edit".  This change updates it
to the correct value by adding an entry to
BrowserAccessibility::GetLocalizedStringForRoleDescription().

Bug: 990386
Change-Id: I92cee38c5fb0b9c81229cb6070784271187f4154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733202Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#685236}

content/app/strings/content_strings.grd

@@ -470,6 +470,10 @@ below:
       <message name="IDS_AX_ROLE_TELEPHONE" desc="Accessibility role description for telephone number input">
         telephone
       </message>
+      <!-- https://w3c.github.io/html-aam/#el-input-url -->
+      <message name="IDS_AX_ROLE_URL" desc="Accessibility role description for URL input">
+        url
+      </message>
       <message name="IDS_AX_ROLE_WEB_AREA" desc="Accessibility role description for web area">
         HTML content
       </message>

content/browser/accessibility/browser_accessibility.cc

@@ -1855,9 +1855,12 @@ base::string16 BrowserAccessibility::GetLocalizedStringForRoleDescription()
     case ax::mojom::Role::kTextField: {
       std::string input_type;
       if (data.GetStringAttribute(ax::mojom::StringAttribute::kInputType,
-                                  &input_type) &&
-          input_type == "tel") {
+                                  &input_type)) {
+        if (input_type == "tel") {
           return content_client->GetLocalizedString(IDS_AX_ROLE_TELEPHONE);
+        } else if (input_type == "url") {
+          return content_client->GetLocalizedString(IDS_AX_ROLE_URL);
+        }
       }
       return {};
     }

content/browser/accessibility/cross_platform_accessibility_browsertest.cc

@@ -707,7 +707,8 @@ IN_PROC_BROWSER_TEST_F(CrossPlatformAccessibilityBrowserTest,
   GURL url(
       "data:text/html,"
       "<input>"
-      "<input type='tel'>");
+      "<input type='tel'>"
+      "<input type='url'>");
 
   NavigateToURL(shell(), url);
   waiter.WaitForNotification();
@@ -717,7 +718,7 @@ IN_PROC_BROWSER_TEST_F(CrossPlatformAccessibilityBrowserTest,
   ASSERT_EQ(1u, root->PlatformChildCount());
 
   BrowserAccessibility* body = root->PlatformGetChild(0);
-  ASSERT_EQ(2u, body->PlatformChildCount());
+  ASSERT_EQ(3u, body->PlatformChildCount());
 
   auto TestLocalizedRoleDescription =
       [body](int child_index,
@@ -732,6 +733,7 @@ IN_PROC_BROWSER_TEST_F(CrossPlatformAccessibilityBrowserTest,
   // For testing purposes, assume we get en-US localized strings.
   TestLocalizedRoleDescription(0, base::ASCIIToUTF16(""));
   TestLocalizedRoleDescription(1, base::ASCIIToUTF16("telephone"));
+  TestLocalizedRoleDescription(2, base::ASCIIToUTF16("url"));
 }
 
 IN_PROC_BROWSER_TEST_F(CrossPlatformAccessibilityBrowserTest,

content/test/data/accessibility/html/input-url-expected-uia-win.txt

-document
-++group
-++++textbox Value.Value='example.com'
+document LocalizedControlType='document'
+++group LocalizedControlType='group'
+++++textbox LocalizedControlType='url' Value.Value='example.com'

content/test/data/accessibility/html/input-url-expected-win.txt

 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>' n_selections=0
 ++IA2_ROLE_SECTION ia2_hypertext='<obj0>' n_selections=0
-++++ROLE_SYSTEM_TEXT value='example.com' FOCUSABLE IA2_STATE_INVALID_ENTRY text-input-type:url ia2_hypertext='example.com' caret_offset=0 n_selections=0
+++++ROLE_SYSTEM_TEXT value='example.com' FOCUSABLE IA2_STATE_INVALID_ENTRY text-input-type:url ia2_hypertext='example.com' caret_offset=0 n_selections=0 localized_extended_role='url'

content/test/data/accessibility/html/input-url.html

 <!--
+@BLINK-ALLOW:inputType=*
+@UIA-WIN-ALLOW:LocalizedControlType=*
 @MAC-ALLOW:AXRole*
 @WIN-ALLOW:caret_offset*
 @WIN-ALLOW:ia2_hypertext=*
+@WIN-ALLOW:localized_extended_role=*
 @WIN-ALLOW:n_selections*
 @WIN-ALLOW:selection_start*
 @WIN-ALLOW:selection_end*

ui/accessibility/platform/test_ax_node_wrapper.cc

@@ -561,9 +561,12 @@ base::string16 TestAXNodeWrapper::GetLocalizedStringForRoleDescription() const {
     case ax::mojom::Role::kTextField: {
       std::string input_type;
       if (data.GetStringAttribute(ax::mojom::StringAttribute::kInputType,
-                                  &input_type) &&
-          input_type == "tel") {
+                                  &input_type)) {
+        if (input_type == "tel") {
           return base::ASCIIToUTF16("telephone");
+        } else if (input_type == "url") {
+          return base::ASCIIToUTF16("url");
+        }
       }
       return {};
     }