Commit 614625d8 authored by alph's avatar alph Committed by Commit bot

DevTools: Add "New" button to launch timeline landing page.

BUG=570441

Review-Url: https://codereview.chromium.org/2584783002
Cr-Commit-Position: refs/heads/master@{#439069}
parent c07e9458
...@@ -293,6 +293,10 @@ Timeline.TimelinePanel = class extends UI.Panel { ...@@ -293,6 +293,10 @@ Timeline.TimelinePanel = class extends UI.Panel {
// Record // Record
if (Runtime.experiments.isEnabled('timelineLandingPage')) { if (Runtime.experiments.isEnabled('timelineLandingPage')) {
const newButton = new UI.ToolbarButton(
Common.UIString('New recording'), 'largeicon-add', Common.UIString('New'));
newButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
this._panelToolbar.appendToolbarItem(newButton);
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction)); this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction));
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('main.reload')); this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('main.reload'));
} else if (Runtime.experiments.isEnabled('timelineRecordingPerspectives') && } else if (Runtime.experiments.isEnabled('timelineRecordingPerspectives') &&
...@@ -305,9 +309,11 @@ Timeline.TimelinePanel = class extends UI.Panel { ...@@ -305,9 +309,11 @@ Timeline.TimelinePanel = class extends UI.Panel {
} }
// Clear // Clear
var clearButton = new UI.ToolbarButton(Common.UIString('Clear recording'), 'largeicon-clear'); if (!Runtime.experiments.isEnabled('timelineLandingPage')) {
const clearButton = new UI.ToolbarButton(Common.UIString('Clear recording'), 'largeicon-clear');
clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this); clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
this._panelToolbar.appendToolbarItem(clearButton); this._panelToolbar.appendToolbarItem(clearButton);
}
this._panelToolbar.appendSeparator(); this._panelToolbar.appendSeparator();
...@@ -371,6 +377,7 @@ Timeline.TimelinePanel = class extends UI.Panel { ...@@ -371,6 +377,7 @@ Timeline.TimelinePanel = class extends UI.Panel {
this._onModeChanged(); this._onModeChanged();
} }
// Checkboxes
if (Runtime.experiments.isEnabled('timelineLandingPage')) { if (Runtime.experiments.isEnabled('timelineLandingPage')) {
if (!this._model.isEmpty()) { if (!this._model.isEmpty()) {
this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Common.UIString('Memory'), this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Common.UIString('Memory'),
...@@ -421,14 +428,16 @@ Timeline.TimelinePanel = class extends UI.Panel { ...@@ -421,14 +428,16 @@ Timeline.TimelinePanel = class extends UI.Panel {
this._panelToolbar.appendToolbarItem(checkbox); this._panelToolbar.appendToolbarItem(checkbox);
} }
} }
this._panelToolbar.appendSeparator();
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('components.collect-garbage'));
this._panelToolbar.appendSeparator(); this._panelToolbar.appendSeparator();
this._cpuThrottlingCombobox = new UI.ToolbarComboBox(this._onCPUThrottlingChanged.bind(this)); this._cpuThrottlingCombobox = new UI.ToolbarComboBox(this._onCPUThrottlingChanged.bind(this));
this._panelToolbar.appendToolbarItem(this._createNetworkConditionsSelect()); this._panelToolbar.appendToolbarItem(this._createNetworkConditionsSelect());
this._panelToolbar.appendToolbarItem(this._cpuThrottlingCombobox); this._panelToolbar.appendToolbarItem(this._cpuThrottlingCombobox);
this._populateCPUThrottingCombobox(); this._populateCPUThrottingCombobox();
this._panelToolbar.appendSeparator();
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('components.collect-garbage'));
this._updateTimelineControls(); this._updateTimelineControls();
} }
......
...@@ -87,7 +87,7 @@ ...@@ -87,7 +87,7 @@
} }
.toolbar-has-glyph .toolbar-text { .toolbar-has-glyph .toolbar-text {
margin-left: 0; margin-left: -4px;
} }
.toolbar-button:not(.toolbar-has-glyph):not(.toolbar-has-dropdown):not(.largeicon-menu) { .toolbar-button:not(.toolbar-has-glyph):not(.toolbar-has-dropdown):not(.largeicon-menu) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment