Commit 62fad45e authored by Mason Freed's avatar Mason Freed Committed by Commit Bot

Fix ARIA attribute reflection for aria-selected and aria-setsize

Prior to this CL, the setsize and selected attributes were incorrectly
linked. There are now two separate attributes with their own reflected
properties.

Bug: 914469
Change-Id: I73c26e3685fc758537cbe0eb9e3bb98becc75bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148112
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759087}
parent fac7cefc
...@@ -39,7 +39,8 @@ ...@@ -39,7 +39,8 @@
[CEReactions, Reflect=aria_rowcount] attribute DOMString? ariaRowCount; [CEReactions, Reflect=aria_rowcount] attribute DOMString? ariaRowCount;
[CEReactions, Reflect=aria_rowindex] attribute DOMString? ariaRowIndex; [CEReactions, Reflect=aria_rowindex] attribute DOMString? ariaRowIndex;
[CEReactions, Reflect=aria_rowspan] attribute DOMString? ariaRowSpan; [CEReactions, Reflect=aria_rowspan] attribute DOMString? ariaRowSpan;
[CEReactions, Reflect=aria_setsize] attribute DOMString? ariaSelected; [CEReactions, Reflect=aria_selected] attribute DOMString? ariaSelected;
[CEReactions, Reflect=aria_setsize] attribute DOMString? ariaSetSize;
[CEReactions, Reflect=aria_sort] attribute DOMString? ariaSort; [CEReactions, Reflect=aria_sort] attribute DOMString? ariaSort;
[CEReactions, Reflect=aria_valuemax] attribute DOMString? ariaValueMax; [CEReactions, Reflect=aria_valuemax] attribute DOMString? ariaValueMax;
[CEReactions, Reflect=aria_valuemin] attribute DOMString? ariaValueMin; [CEReactions, Reflect=aria_valuemin] attribute DOMString? ariaValueMin;
......
...@@ -360,13 +360,24 @@ test(function(t) { ...@@ -360,13 +360,24 @@ test(function(t) {
}, "aria-rowspan attribute reflects."); }, "aria-rowspan attribute reflects.");
</script> </script>
<div id="selected" aria-selected="true"></div>
<script>
test(function(t) {
var element = document.getElementById("selected");
assert_equals(element.ariaSelected, "true");
element.ariaSelected = "false";
assert_equals(element.getAttribute("aria-selected"), "false");
}, "aria-selected attribute reflects.");
</script>
<div id="setsize" aria-setsize="10"></div> <div id="setsize" aria-setsize="10"></div>
<script> <script>
test(function(t) { test(function(t) {
var element = document.getElementById("setsize"); var element = document.getElementById("setsize");
assert_equals(element.ariaSelected, "10"); assert_equals(element.ariaSetSize, "10");
element.ariaSelected = "11"; element.ariaSetSize = "11";
assert_equals(element.getAttribute("aria-setsize"), "11"); assert_equals(element.getAttribute("aria-setsize"), "11");
}, "aria-setsize attribute reflects."); }, "aria-setsize attribute reflects.");
</script> </script>
......
...@@ -61,6 +61,7 @@ namespace http://www.w3.org/1999/xhtml ...@@ -61,6 +61,7 @@ namespace http://www.w3.org/1999/xhtml
property ariaRowIndex property ariaRowIndex
property ariaRowSpan property ariaRowSpan
property ariaSelected property ariaSelected
property ariaSetSize
property ariaSort property ariaSort
property ariaValueMax property ariaValueMax
property ariaValueMin property ariaValueMin
...@@ -1218,6 +1219,7 @@ namespace http://www.w3.org/2000/svg ...@@ -1218,6 +1219,7 @@ namespace http://www.w3.org/2000/svg
property ariaRowIndex property ariaRowIndex
property ariaRowSpan property ariaRowSpan
property ariaSelected property ariaSelected
property ariaSetSize
property ariaSort property ariaSort
property ariaValueMax property ariaValueMax
property ariaValueMin property ariaValueMin
......
...@@ -1664,6 +1664,7 @@ interface Element : Node ...@@ -1664,6 +1664,7 @@ interface Element : Node
getter ariaRowIndex getter ariaRowIndex
getter ariaRowSpan getter ariaRowSpan
getter ariaSelected getter ariaSelected
getter ariaSetSize
getter ariaSort getter ariaSort
getter ariaValueMax getter ariaValueMax
getter ariaValueMin getter ariaValueMin
...@@ -1791,6 +1792,7 @@ interface Element : Node ...@@ -1791,6 +1792,7 @@ interface Element : Node
setter ariaRowIndex setter ariaRowIndex
setter ariaRowSpan setter ariaRowSpan
setter ariaSelected setter ariaSelected
setter ariaSetSize
setter ariaSort setter ariaSort
setter ariaValueMax setter ariaValueMax
setter ariaValueMin setter ariaValueMin
...@@ -1849,6 +1851,7 @@ interface ElementInternals ...@@ -1849,6 +1851,7 @@ interface ElementInternals
getter ariaRowIndex getter ariaRowIndex
getter ariaRowSpan getter ariaRowSpan
getter ariaSelected getter ariaSelected
getter ariaSetSize
getter ariaSort getter ariaSort
getter ariaValueMax getter ariaValueMax
getter ariaValueMin getter ariaValueMin
...@@ -1896,6 +1899,7 @@ interface ElementInternals ...@@ -1896,6 +1899,7 @@ interface ElementInternals
setter ariaRowIndex setter ariaRowIndex
setter ariaRowSpan setter ariaRowSpan
setter ariaSelected setter ariaSelected
setter ariaSetSize
setter ariaSort setter ariaSort
setter ariaValueMax setter ariaValueMax
setter ariaValueMin setter ariaValueMin
......
...@@ -70,6 +70,7 @@ namespace http://www.w3.org/1999/xhtml ...@@ -70,6 +70,7 @@ namespace http://www.w3.org/1999/xhtml
property ariaRowIndex property ariaRowIndex
property ariaRowSpan property ariaRowSpan
property ariaSelected property ariaSelected
property ariaSetSize
property ariaSort property ariaSort
property ariaValueMax property ariaValueMax
property ariaValueMin property ariaValueMin
...@@ -1279,6 +1280,7 @@ namespace http://www.w3.org/2000/svg ...@@ -1279,6 +1280,7 @@ namespace http://www.w3.org/2000/svg
property ariaRowIndex property ariaRowIndex
property ariaRowSpan property ariaRowSpan
property ariaSelected property ariaSelected
property ariaSetSize
property ariaSort property ariaSort
property ariaValueMax property ariaValueMax
property ariaValueMin property ariaValueMin
......
...@@ -2024,6 +2024,7 @@ interface Element : Node ...@@ -2024,6 +2024,7 @@ interface Element : Node
getter ariaRowIndex getter ariaRowIndex
getter ariaRowSpan getter ariaRowSpan
getter ariaSelected getter ariaSelected
getter ariaSetSize
getter ariaSort getter ariaSort
getter ariaValueMax getter ariaValueMax
getter ariaValueMin getter ariaValueMin
...@@ -2167,6 +2168,7 @@ interface Element : Node ...@@ -2167,6 +2168,7 @@ interface Element : Node
setter ariaRowIndex setter ariaRowIndex
setter ariaRowSpan setter ariaRowSpan
setter ariaSelected setter ariaSelected
setter ariaSetSize
setter ariaSort setter ariaSort
setter ariaValueMax setter ariaValueMax
setter ariaValueMin setter ariaValueMin
...@@ -2235,6 +2237,7 @@ interface ElementInternals ...@@ -2235,6 +2237,7 @@ interface ElementInternals
getter ariaRowIndex getter ariaRowIndex
getter ariaRowSpan getter ariaRowSpan
getter ariaSelected getter ariaSelected
getter ariaSetSize
getter ariaSort getter ariaSort
getter ariaValueMax getter ariaValueMax
getter ariaValueMin getter ariaValueMin
...@@ -2292,6 +2295,7 @@ interface ElementInternals ...@@ -2292,6 +2295,7 @@ interface ElementInternals
setter ariaRowIndex setter ariaRowIndex
setter ariaRowSpan setter ariaRowSpan
setter ariaSelected setter ariaSelected
setter ariaSetSize
setter ariaSort setter ariaSort
setter ariaValueMax setter ariaValueMax
setter ariaValueMin setter ariaValueMin
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment