Commit 6368fb03 authored by dslomov@google.com's avatar dslomov@google.com

TestWebKitAPI breaks on Windows due to fast malloc incompatibility.

https://bugs.webkit.org/show_bug.cgi?id=66521

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.

Reviewed by David Levin.

* gtest/include/gtest/internal/gtest-port.h:
* gtest/msvc/gtest-md.vcproj:
* gtest/README.WebKit:
* gtest/xcode/Config/General.xcconfig:
* gtest/xcode/gtest.xcodeproj/project.pbxproj:

Tools:

This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=66521

Reviewed by David Levin.

* TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.

git-svn-id: svn://svn.chromium.org/blink/trunk@93426 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 79de6e0d
2011-08-18 Dmitry Lomov <dslomov@google.com>
TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
Reviewed by David Levin.
* gtest/include/gtest/internal/gtest-port.h:
* gtest/msvc/gtest-md.vcproj:
* gtest/README.WebKit:
* gtest/xcode/Config/General.xcconfig:
* gtest/xcode/gtest.xcodeproj/project.pbxproj:
2011-08-09 Mark Rowe <mrowe@apple.com> 2011-08-09 Mark Rowe <mrowe@apple.com>
Fix gtest to compile in the release configuration with clang. Fix gtest to compile in the release configuration with clang.
......
...@@ -2,5 +2,10 @@ GTest v.1.5.0 ...@@ -2,5 +2,10 @@ GTest v.1.5.0
http://googletest.googlecode.com/svn/tags/release-1.5.0/ http://googletest.googlecode.com/svn/tags/release-1.5.0/
2011-08-19 Dmitry Lomov (dslomov@google.com)
- WebKit port of gtest uses universal "new" and "delete" operators from JavaScriptCore.
- removed all dynamic targets from gtest.xcodeproject (we only build static libgtest.a
and statically-linked gtest unit-test runner).
2011-05-06 Dmitry Lomov (dslomov@google.com) 2011-05-06 Dmitry Lomov (dslomov@google.com)
gtest-md.vcproj upgraded to VS 2005 (8.0) format to match the rest of WebKit gtest-md.vcproj upgraded to VS 2005 (8.0) format to match the rest of WebKit
...@@ -177,6 +177,24 @@ ...@@ -177,6 +177,24 @@
#include <sys/stat.h> #include <sys/stat.h>
#endif // !_WIN32_WCE #endif // !_WIN32_WCE
#include <wtf/Platform.h>
#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !defined(BUILDING_WX__) && !COMPILER(GCC)
#define JS_EXPORTDATA __declspec(dllimport)
#define WEBKIT_EXPORTDATA __declspec(dllimport)
#define WTF_EXPORT_PRIVATE
#define JS_EXPORT_PRIVATE
#define JS_EXPORTCLASS JS_EXPORTDATA
#else
#define JS_EXPORTDATA
#define JS_EXPORTCLASS
#define WEBKIT_EXPORTDATA
#define WTF_EXPORT_PRIVATE
#define JS_EXPORT_PRIVATE
#endif
#include <wtf/FastMalloc.h>
#include <iostream> // NOLINT #include <iostream> // NOLINT
#include <sstream> // NOLINT #include <sstream> // NOLINT
#include <string> // NOLINT #include <string> // NOLINT
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
OutputDirectory="$(ConfigurationBuildDir)\lib" OutputDirectory="$(ConfigurationBuildDir)\lib"
IntermediateDirectory="$(ConfigurationBuildDir)\obj\$(ProjectName)" IntermediateDirectory="$(ConfigurationBuildDir)\obj\$(ProjectName)"
ConfigurationType="4" ConfigurationType="4"
InheritedPropertySheets="$(ProjectDir)\..\..\..\..\WebKitLibraries\win\tools\vsprops\common.vsprops" InheritedPropertySheets="&quot;$(ProjectDir)\..\..\..\..\WebKitLibraries\win\tools\vsprops\common.vsprops&quot;"
CharacterSet="2" CharacterSet="2"
> >
<Tool <Tool
...@@ -40,6 +40,7 @@ ...@@ -40,6 +40,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
Optimization="0" Optimization="0"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB" PreprocessorDefinitions="WIN32;_DEBUG;_LIB"
MinimalRebuild="true" MinimalRebuild="true"
...@@ -103,6 +104,7 @@ ...@@ -103,6 +104,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB" PreprocessorDefinitions="WIN32;NDEBUG;_LIB"
RuntimeLibrary="2" RuntimeLibrary="2"
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
...@@ -164,6 +166,7 @@ ...@@ -164,6 +166,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
Optimization="0" Optimization="0"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB" PreprocessorDefinitions="WIN32;_DEBUG;_LIB"
MinimalRebuild="true" MinimalRebuild="true"
...@@ -228,6 +231,7 @@ ...@@ -228,6 +231,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB" PreprocessorDefinitions="WIN32;NDEBUG;_LIB"
RuntimeLibrary="2" RuntimeLibrary="2"
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
...@@ -289,6 +293,7 @@ ...@@ -289,6 +293,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
PreprocessorDefinitions="WIN32;NDEBUG;_LIB" PreprocessorDefinitions="WIN32;NDEBUG;_LIB"
RuntimeLibrary="2" RuntimeLibrary="2"
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
...@@ -350,6 +355,7 @@ ...@@ -350,6 +355,7 @@
/> />
<Tool <Tool
Name="VCCLCompilerTool" Name="VCCLCompilerTool"
AdditionalIncludeDirectories="&quot;$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders&quot;;&quot;$(ConfigurationBuildDir)\include\private&quot;"
Optimization="0" Optimization="0"
PreprocessorDefinitions="WIN32;_DEBUG;_LIB" PreprocessorDefinitions="WIN32;_DEBUG;_LIB"
MinimalRebuild="true" MinimalRebuild="true"
......
...@@ -10,6 +10,8 @@ ...@@ -10,6 +10,8 @@
// Build for PPC and Intel, 32- and 64-bit // Build for PPC and Intel, 32- and 64-bit
ARCHS = i386 x86_64 ARCHS = i386 x86_64
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/WebCore.framework/PrivateHeaders/ForwardingHeaders ../ ../include/
// Zerolink prevents link warnings so turn it off // Zerolink prevents link warnings so turn it off
ZERO_LINK = NO ZERO_LINK = NO
......
2011-08-18 Dmitry Lomov <dslomov@google.com>
TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
Reviewed by David Levin.
* TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2011-08-19 Adam Roben <aroben@apple.com> 2011-08-19 Adam Roben <aroben@apple.com>
Add project file changes I left out in r93417 Add project file changes I left out in r93417
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
* THE POSSIBILITY OF SUCH DAMAGE. * THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#define JS_EXPORTDATA
#define WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() (++wtfStringCopyCount) #define WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() (++wtfStringCopyCount)
static int wtfStringCopyCount; static int wtfStringCopyCount;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment