Commit 63ef97f2 authored by Monica Basta's avatar Monica Basta Committed by Commit Bot

[Signin]: Fix crash in |signin_email_confirmation_ui|.

We get a crash in the |signin_email_confirmation_ui| due to a |DCHECK|
|HasUnexpectedPlaceholder()|that checks that the replacement does not
have an unsubstituted placeholder.  The |DCHECK| runs before some of the
placeholders get replaced by JavaScript.  To avoid this crash, we
remove the placeholders from |signin_email_confirmation.html| and rely
on JavaScript to replace correctly the text.

Change-Id: Ib56b8fbc4ae0d042ecffb53912a111a4964afb11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878769Reviewed-by: default avatarMichael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719549}
parent 2e8aa0d1
...@@ -46,7 +46,6 @@ ...@@ -46,7 +46,6 @@
</style> </style>
<div class="container"> <div class="container">
<div class="top-title-bar" id='dialogTitle'> <div class="top-title-bar" id='dialogTitle'>
$i18n{signinEmailConfirmationTitle}
</div> </div>
<div class="details"> <div class="details">
<cr-radio-group selected="createNewUser"> <cr-radio-group selected="createNewUser">
...@@ -57,7 +56,6 @@ ...@@ -57,7 +56,6 @@
</div> </div>
<div class="radio-button-subtitle-container" <div class="radio-button-subtitle-container"
id="createNewUserRadioButtonSubtitle"> id="createNewUserRadioButtonSubtitle">
$i18n{signinEmailConfirmationCreateProfileButtonSubtitle}
</div> </div>
</cr-radio-button> </cr-radio-button>
<cr-radio-button id="startSyncRadioButton" name="startSync"> <cr-radio-button id="startSyncRadioButton" name="startSync">
...@@ -66,7 +64,6 @@ ...@@ -66,7 +64,6 @@
</div> </div>
<div class="radio-button-subtitle-container" <div class="radio-button-subtitle-container"
id="startSyncRadioButtonSubtitle"> id="startSyncRadioButtonSubtitle">
$i18n{signinEmailConfirmationStartSyncButtonSubtitle}
</div> </div>
</cr-radio-button> </cr-radio-button>
</cr-radio-group> </cr-radio-group>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment