Commit 6401ecb8 authored by Erik Språng's avatar Erik Språng Committed by Commit Bot

Add EncoderInfo support to RtcVideoEncoder

This CL adds support for the new GetEncoderInfo() method which will
replace GetScalingSettings(), SupportsNativeHandle() and
ImplementationName(). These methods will be removed in a follow-up cl.

It also removes assignment of CodecSpecificInfo.codec_name, which is
also going away.



Bug: webrtc:9890
Change-Id: I9d910dde4fefb054a04f9585579992f1cfc696c6
Reviewed-on: https://chromium-review.googlesource.com/c/1301514Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
Commit-Queue: Erik Språng <sprang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603620}
parent 03b56190
......@@ -797,7 +797,6 @@ void RTCVideoEncoder::Impl::ReturnEncodedImage(
webrtc::CodecSpecificInfo info;
memset(&info, 0, sizeof(info));
info.codecType = video_codec_type_;
info.codec_name = ImplementationName();
if (video_codec_type_ == webrtc::kVideoCodecVP8) {
info.codecSpecific.VP8.keyIdx = -1;
}
......@@ -977,4 +976,11 @@ const char* RTCVideoEncoder::ImplementationName() const {
return RTCVideoEncoder::Impl::ImplementationName();
}
webrtc::VideoEncoder::EncoderInfo RTCVideoEncoder::GetEncoderInfo() const {
EncoderInfo info;
info.implementation_name = RTCVideoEncoder::Impl::ImplementationName();
info.supports_native_handle = true;
return info;
}
} // namespace content
......@@ -62,6 +62,7 @@ class CONTENT_EXPORT RTCVideoEncoder : public webrtc::VideoEncoder {
uint32_t framerate) override;
bool SupportsNativeHandle() const override;
const char* ImplementationName() const override;
EncoderInfo GetEncoderInfo() const override;
private:
class Impl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment