Commit 64b1c74a authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Fix PasswordBubbleInteractiveUiTest tests to support the sticky bubble.

Bug: 1003362
Change-Id: Ic403601498287275fbfbe6a511ace44cd8dede83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800989Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696033}
parent 60b4aa92
...@@ -26,6 +26,7 @@ ...@@ -26,6 +26,7 @@
#include "chrome/browser/ui/views/toolbar/toolbar_view.h" #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/test/base/interactive_test_utils.h" #include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h" #include "chrome/test/base/ui_test_utils.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "content/public/browser/notification_types.h" #include "content/public/browser/notification_types.h"
#include "content/public/browser/render_view_host.h" #include "content/public/browser/render_view_host.h"
#include "content/public/test/test_utils.h" #include "content/public/test/test_utils.h"
...@@ -227,7 +228,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnClick) { ...@@ -227,7 +228,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnClick) {
->GetFocusManager() ->GetFocusManager()
->GetFocusedView()); ->GetFocusedView());
ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER); ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER);
EXPECT_FALSE(IsBubbleShowing()); EXPECT_EQ(IsBubbleShowing(), base::FeatureList::IsEnabled(
password_manager::features::kStickyBubble));
} }
IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnEsc) { IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnEsc) {
...@@ -235,7 +237,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnEsc) { ...@@ -235,7 +237,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnEsc) {
EXPECT_TRUE(IsBubbleShowing()); EXPECT_TRUE(IsBubbleShowing());
ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE, false, ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE, false,
false, false, false)); false, false, false));
EXPECT_FALSE(IsBubbleShowing()); EXPECT_EQ(IsBubbleShowing(), base::FeatureList::IsEnabled(
password_manager::features::kStickyBubble));
} }
IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnKey) { IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnKey) {
...@@ -257,7 +260,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnKey) { ...@@ -257,7 +260,8 @@ IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, CloseOnKey) {
EXPECT_TRUE(web_contents->IsFocusedElementEditable()); EXPECT_TRUE(web_contents->IsFocusedElementEditable());
ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_K, false, ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_K, false,
false, false, false)); false, false, false));
EXPECT_FALSE(IsBubbleShowing()); EXPECT_EQ(IsBubbleShowing(), base::FeatureList::IsEnabled(
password_manager::features::kStickyBubble));
} }
IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest, IN_PROC_BROWSER_TEST_F(PasswordBubbleInteractiveUiTest,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment