Commit 64f4ec22 authored by Nicolás Peña's avatar Nicolás Peña Committed by Commit Bot

Check if GetResourceLoadTiming is null in GenerateResourceTiming

Bug: 773591
Change-Id: Id49125101500155aa291fb7d3d13ff6ae2e4889d
Reviewed-on: https://chromium-review.googlesource.com/940285
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540092}
parent e9fc1b31
......@@ -359,11 +359,18 @@ WebResourceTimingInfo Performance::GenerateResourceTiming(
AllowsTimingRedirect(redirect_chain, final_response, destination_origin,
&context_for_use_counter);
result.last_redirect_end_time = TimeTicksInSeconds(
redirect_chain.back().GetResourceLoadTiming()->ReceiveHeadersEnd());
// TODO(https://crbug.com/817691): is |last_chained_timing| being null a bug
// or is this if statement reasonable?
if (ResourceLoadTiming* last_chained_timing =
redirect_chain.back().GetResourceLoadTiming()) {
result.last_redirect_end_time =
TimeTicksInSeconds(last_chained_timing->ReceiveHeadersEnd());
} else {
result.allow_redirect_details = false;
result.last_redirect_end_time = 0.0;
}
if (!result.allow_redirect_details) {
// TODO(https://crbug.com/803913): There was previously a DCHECK that
// TODO(https://crbug.com/817691): There was previously a DCHECK that
// |final_timing| is non-null. However, it clearly can be null: removing
// this check caused https://crbug.com/803811. Figure out how this can
// happen so test coverage can be added.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment