Add automatic clicks feature flag.

Bug: 907180
Change-Id: Iad8aafe80e76d7f7ebfafacbccfdda48e1c4bbf5
Reviewed-on: https://chromium-review.googlesource.com/c/1344902
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611204}

chrome/browser/about_flags.cc

@@ -2734,6 +2734,10 @@ const FeatureEntry kFeatureEntries[] = {
     {"enable-cros-ime-service", flag_descriptions::kImeServiceName,
      flag_descriptions::kImeServiceDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(chromeos::features::kImeServiceConnectable)},
+    {"enable-experimental-accessibility-autoclick",
+     flag_descriptions::kExperimentalAccessibilityAutoclickName,
+     flag_descriptions::kExperimentalAccessibilityAutoclickDescription, kOsCrOS,
+     SINGLE_VALUE_TYPE(::switches::kEnableExperimentalAccessibilityAutoclick)},
     {"enable-experimental-accessibility-switch-access",
      flag_descriptions::kExperimentalAccessibilitySwitchAccessName,
      flag_descriptions::kExperimentalAccessibilitySwitchAccessDescription,

chrome/browser/flag-metadata.json

@@ -1143,6 +1143,11 @@
     // "owners": [ "your-team" ],
     "expiry_milestone": 76
   },
+  {
+    "name": "enable-experimental-accessibility-autoclick",
+    "owners": [ "katie", "dmazzoni", "dtseng" ],
+    "expiry_milestone": 78
+  },
   {
     "name": "enable-experimental-crostini-ui",
     "owners": [ "nverne", "benwells" ],

chrome/browser/flag_descriptions.cc

@@ -697,6 +697,11 @@ const char kExperimentalAccessibilityFeaturesName[] =
 const char kExperimentalAccessibilityFeaturesDescription[] =
     "Enable additional accessibility features in the Settings page.";
 
+const char kExperimentalAccessibilityAutoclickName[] =
+    "Experimental automatic click features";
+const char kExperimentalAccessibilityAutoclickDescription[] =
+    "Enable additional features for automatic clicks.";
+
 const char kExperimentalAccessibilitySwitchAccessName[] =
     "Experimental feature Switch Access";
 const char kExperimentalAccessibilitySwitchAccessDescription[] =

chrome/browser/flag_descriptions.h

@@ -159,6 +159,9 @@ extern const char kCloudPrinterHandlerDescription[];
 extern const char kExperimentalAccessibilityFeaturesName[];
 extern const char kExperimentalAccessibilityFeaturesDescription[];
 
+extern const char kExperimentalAccessibilityAutoclickName[];
+extern const char kExperimentalAccessibilityAutoclickDescription[];
+
 extern const char kExperimentalAccessibilitySwitchAccessName[];
 extern const char kExperimentalAccessibilitySwitchAccessDescription[];
 

chrome/browser/resources/settings/a11y_page/manage_a11y_page.html

@@ -213,7 +213,7 @@
           disabled="[[!prefs.settings.a11y.autoclick.value]]">
       </settings-dropdown-menu>
     </div>
-    <template is="dom-if" if="[[showExperimentalFeatures_]]">
+    <template is="dom-if" if="[[showExperimentalAutoclick_]]">
       <div class="settings-box continuation"
           hidden$="[[!prefs.settings.a11y.autoclick.value]]">
         <div class="start sub-item" id="autoclickEventTypeLabel">

chrome/browser/resources/settings/a11y_page/manage_a11y_page.js

@@ -147,6 +147,14 @@ Polymer({
       },
     },
 
+    showExperimentalAutoclick_: {
+      type: Boolean,
+      value: function() {
+        return loadTimeData.getBoolean(
+            'showExperimentalAccessibilityAutoclick');
+      },
+    },
+
     showExperimentalSwitchAccess_: {
       type: Boolean,
       value: function() {

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -333,6 +333,11 @@ void AddA11yStrings(content::WebUIDataSource* html_source) {
       base::CommandLine::ForCurrentProcess()->HasSwitch(
           ::switches::kEnableExperimentalAccessibilityFeatures));
 
+  html_source->AddBoolean(
+      "showExperimentalAccessibilityAutoclick",
+      base::CommandLine::ForCurrentProcess()->HasSwitch(
+          ::switches::kEnableExperimentalAccessibilityAutoclick));
+
   html_source->AddBoolean(
       "showExperimentalAccessibilitySwitchAccess",
       base::CommandLine::ForCurrentProcess()->HasSwitch(

tools/metrics/histograms/enums.xml

@@ -30513,6 +30513,7 @@ from previous Chrome versions.
   <int value="348115702" label="new-password-form-parsing-for-saving:enabled"/>
   <int value="348854923" label="v8-cache-strategies-for-cache-storage"/>
   <int value="350399958" label="ModuleScriptsImportMetaUrl:disabled"/>
+  <int value="351005753" label="enable-experimental-accessibility-autoclick"/>
   <int value="352191859" label="disabled-new-style-notification"/>
   <int value="352937987" label="OverflowIconsForMediaControls:disabled"/>
   <int value="357138275" label="enable-floating-virtual-keyboard:disabled"/>

ui/accessibility/accessibility_switches.cc

@@ -13,6 +13,10 @@ namespace switches {
 const char kEnableExperimentalAccessibilityFeatures[] =
     "enable-experimental-accessibility-features";
 
+// Shows additional automatic click features that haven't launched yet.
+const char kEnableExperimentalAccessibilityAutoclick[] =
+    "enable-experimental-accessibility-autoclick";
+
 // Shows setting to enable Switch Access before it has launched.
 const char kEnableExperimentalAccessibilitySwitchAccess[] =
     "enable-experimental-accessibility-switch-access";

ui/accessibility/accessibility_switches.h

@@ -11,6 +11,7 @@
 namespace switches {
 
 AX_EXPORT extern const char kEnableExperimentalAccessibilityFeatures[];
+AX_EXPORT extern const char kEnableExperimentalAccessibilityAutoclick[];
 AX_EXPORT extern const char kEnableExperimentalAccessibilitySwitchAccess[];
 
 // Returns true if experimental accessibility features are enabled.