Commit 65ce6c73 authored by Peter K. Lee's avatar Peter K. Lee Committed by Commit Bot

Removes CreateAppRatingPrompt() from chrome_browser_provider API

There are no more users of this API.

Bug: 863559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I96b5d14bc53093f6e5a02c57191fbb9f4c108b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1280849Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599706}
parent 5f4817ed
...@@ -34,7 +34,6 @@ namespace web { ...@@ -34,7 +34,6 @@ namespace web {
class WebState; class WebState;
} }
@protocol AppRatingPrompt;
@protocol LogoVendor; @protocol LogoVendor;
@protocol TextFieldStyling; @protocol TextFieldStyling;
@class Tab; @class Tab;
...@@ -112,10 +111,6 @@ class ChromeBrowserProvider { ...@@ -112,10 +111,6 @@ class ChromeBrowserProvider {
// Creates and returns a new styled text field with the given |frame|. // Creates and returns a new styled text field with the given |frame|.
virtual UITextField<TextFieldStyling>* CreateStyledTextField( virtual UITextField<TextFieldStyling>* CreateStyledTextField(
CGRect frame) const NS_RETURNS_RETAINED; CGRect frame) const NS_RETURNS_RETAINED;
// Creates and returns an app ratings prompt object. Can return nil if app
// ratings prompts are not supported by the provider.
// TODO(crbug.com/863559): DEPRECATED: DO NOT USE
virtual id<AppRatingPrompt> CreateAppRatingPrompt() const NS_RETURNS_RETAINED;
// Initializes the cast service. Should be called soon after the given // Initializes the cast service. Should be called soon after the given
// |main_tab_model| is created. // |main_tab_model| is created.
......
...@@ -73,10 +73,6 @@ UITextField<TextFieldStyling>* ChromeBrowserProvider::CreateStyledTextField( ...@@ -73,10 +73,6 @@ UITextField<TextFieldStyling>* ChromeBrowserProvider::CreateStyledTextField(
return nil; return nil;
} }
id<AppRatingPrompt> ChromeBrowserProvider::CreateAppRatingPrompt() const {
return nil;
}
void ChromeBrowserProvider::InitializeCastService( void ChromeBrowserProvider::InitializeCastService(
TabModel* main_tab_model) const {} TabModel* main_tab_model) const {}
......
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
source_set("ui") { source_set("ui") {
configs += [ "//build/config/compiler:enable_arc" ] configs += [ "//build/config/compiler:enable_arc" ]
sources = [ sources = [
"app_rating_prompt.h",
"default_ios_web_view_factory.h", "default_ios_web_view_factory.h",
"default_ios_web_view_factory.mm", "default_ios_web_view_factory.mm",
"fullscreen_provider.h", "fullscreen_provider.h",
......
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_UI_APP_RATING_PROMPT_H_
#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_UI_APP_RATING_PROMPT_H_
#import <Foundation/Foundation.h>
@class NSURL;
@class UIView;
// AppRatingPromptDelegate declares methods that are called when significant
// actions are performed on an AppRatingPrompt.
// TODO(crbug.com/863559): DEPRECATED: DO NOT USE
@protocol AppRatingPromptDelegate<NSObject>
@optional
// Called when a user taps the "Rate App" button in the prompt.
- (void)userTappedRateApp:(UIView*)view;
// Called when a user taps the "Send Feedback" button in the prompt.
- (void)userTappedSendFeedback:(UIView*)view;
// Called when a user taps the "Dismiss" button in the prompt.
- (void)userTappedDismiss:(UIView*)view;
@end
// An AppRatingPrompt displays a modal dialog prompting the user to rate the
// current app, with additional options to send feedback or dismiss the dialog.
// TODO(crbug.com/863559): DEPRECATED: DO NOT USE
@protocol AppRatingPrompt<NSObject>
@required
// The delegate for this prompt.
@property(nonatomic, readwrite, assign) id<AppRatingPromptDelegate> delegate;
// The URL to launch when the "Rate App" button is tapped. This URL should lead
// to the ratings section of the app store for the current app.
@property(nonatomic, readwrite, retain) NSURL* appStoreURL;
// Presents the prompt on screen. The dialog is dismissed automatically when
// the user taps a button, or it can be programatically dismissed using
// |dismiss|.
- (void)show;
// Programatically dismisses the dialog.
- (void)dismiss;
@end
#endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_UI_APP_RATING_PROMPT_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment