Commit 65d5d583 authored by Chong Gu's avatar Chong Gu Committed by Commit Bot

[Fuchsia] Provide option to overwrite the host tool arch for Fuchsia

By default, the host tools have the same architecture as the target cpu. Provide a variable to indicate when that's not the case.
Add GN SDK scripts to data.

Bug: 1080854
Change-Id: Ia2d55d7f95ddc2574cdd4ba0446ba2e4448a9da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433417Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#811337}
parent 8a90d154
...@@ -16,6 +16,10 @@ declare_args() { ...@@ -16,6 +16,10 @@ declare_args() {
# generated installation scripts. If not specified, then no default directory # generated installation scripts. If not specified, then no default directory
# will be used. # will be used.
default_fuchsia_build_dir_for_installation = "" default_fuchsia_build_dir_for_installation = ""
# Architecture of the host tools included in Fuchsia test targets.
# Defaults to target_cpu.
fuchsia_override_host_tool_arch_for_isolated_testing = target_cpu
} }
# Generates a script which deploys and optionally executes a package on a # Generates a script which deploys and optionally executes a package on a
...@@ -90,6 +94,9 @@ template("fuchsia_package_runner") { ...@@ -90,6 +94,9 @@ template("fuchsia_package_runner") {
"//build/fuchsia/", "//build/fuchsia/",
"//build/util/lib/", "//build/util/lib/",
"//third_party/fuchsia-sdk/sdk/.build-id/", "//third_party/fuchsia-sdk/sdk/.build-id/",
"//third_party/fuchsia-sdk/sdk/bin/fpave.sh",
"//third_party/fuchsia-sdk/sdk/bin/fuchsia-common.sh",
"//third_party/fuchsia-sdk/sdk/meta/manifest.json",
"${boot_image_root}/qemu/qemu-kernel.kernel", "${boot_image_root}/qemu/qemu-kernel.kernel",
"${boot_image_root}/qemu/storage-full.blk", "${boot_image_root}/qemu/storage-full.blk",
"${boot_image_root}/qemu/zircon-a.zbi", "${boot_image_root}/qemu/zircon-a.zbi",
...@@ -99,26 +106,19 @@ template("fuchsia_package_runner") { ...@@ -99,26 +106,19 @@ template("fuchsia_package_runner") {
data += [ "${aemu_root}/" ] data += [ "${aemu_root}/" ]
} }
# Ensure that the host tools required by runner scripts are in runtime deps.
# Note that these must be provided for the test host architecture, which
# currently always matches the |target_cpu|, rather than for the build host
# architecture.
data += [ data += [
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/device-finder", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/device-finder",
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/fvm", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/fvm",
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/merkleroot", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/merkleroot",
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/pm", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/pm",
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/symbolize", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/symbolize",
"//third_party/fuchsia-sdk/sdk/tools/${target_cpu}/zbi", "//third_party/fuchsia-sdk/sdk/tools/${fuchsia_override_host_tool_arch_for_isolated_testing}/zbi",
] ]
if (target_cpu == "arm64") { if (target_cpu == "arm64") {
data += [ "${qemu_arm64_root}/" ] data += [ "${qemu_arm64_root}/" ]
} else { } else {
data += [ data += [
"${qemu_root}/", "${qemu_root}/",
"//third_party/fuchsia-sdk/sdk/bin/fpave.sh",
"//third_party/fuchsia-sdk/sdk/bin/fuchsia-common.sh",
"//third_party/fuchsia-sdk/sdk/meta/manifest.json",
"//third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer", "//third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer",
] ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment