Disable the save button if all checkboxes are unchecked

In the migration dialog, previously the user could click the save button
if the user decided to upload no cards, in which case, we would
still send a no-op Rpc call to Payments.

This was not an ideal situation. Instead, we would disable the save
button and the user can click the cancel button to quit the flow.

Bug: 852904
Change-Id: I6a1e005a63b19046728568b4ce08755616361e08
Reviewed-on: https://chromium-review.googlesource.com/c/1255608
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596041}

chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc

@@ -94,7 +94,7 @@ void LocalCardMigrationDialogView::OnMigrationFinished() {
 }
 
 const std::vector<std::string>
-LocalCardMigrationDialogView::GetSelectedCardGuids() {
+LocalCardMigrationDialogView::GetSelectedCardGuids() const {
   std::vector<std::string> selected_cards;
   for (int index = 0; index < card_list_view_->child_count(); ++index) {
     MigratableCardView* card =
@@ -142,7 +142,14 @@ base::string16 LocalCardMigrationDialogView::GetDialogButtonLabel(
 bool LocalCardMigrationDialogView::IsDialogButtonEnabled(
     ui::DialogButton button) const {
   // The buttons will be disabled when card uploading is in progress.
-  return !migration_pending_;
+  if (migration_pending_)
+    return false;
+
+  // If all checkboxes are unchecked, disable the save button.
+  if (button == ui::DIALOG_BUTTON_OK)
+    return !GetSelectedCardGuids().empty();
+
+  return true;
 }
 
 bool LocalCardMigrationDialogView::Accept() {
@@ -182,6 +189,11 @@ void LocalCardMigrationDialogView::ButtonPressed(views::Button* sender,
   // dialog.
   if (sender == close_migration_dialog_button_) {
     CloseDialog();
+  } else {
+    // Otherwise it is a checkbox just clicked. Enable/disable the save
+    // button if needed.
+    DCHECK_EQ(sender->GetClassName(), views::Checkbox::kViewClassName);
+    DialogModelChanged();
   }
 }
 

chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h

@@ -77,7 +77,7 @@ class LocalCardMigrationDialogView : public LocalCardMigrationDialog,
   void SetMigrationIsPending(bool is_pending);
   void ShowCloseButton();
   void UpdateDialogToPendingView();
-  const std::vector<std::string> GetSelectedCardGuids();
+  const std::vector<std::string> GetSelectedCardGuids() const;
 
   LocalCardMigrationDialogController* controller_;