Commit 68ba239e authored by Francois Doray's avatar Francois Doray Committed by Commit Bot

Skip LockManagerBrowserTest on Android Kit Kat.

Tests fail with error:

../../content/browser/locks/lock_manager_browsertest.cc:88: Failure
Value of: NavigateToURL(shell(), GetLocksURL("a.com"))
  Actual: false
Expected: true
Stack trace:

[2073:2073:1007/121141.431975:FATAL:browser_test_utils.cc(1403)]
Check failed: error.empty(). Can't ExtractBool() because the script
encountered a problem: Error: EvalJs won't work on an already-crashed
frame.

TBR=jsbell@chromium.org

Bug: 1011765
Change-Id: I5945f0d92c9541db11325d076e9bd26f26268b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845152Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703301}
parent 02767228
...@@ -20,6 +20,10 @@ ...@@ -20,6 +20,10 @@
#include "testing/gmock/include/gmock/gmock.h" #include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_ANDROID)
#include "base/android/build_info.h"
#endif
namespace content { namespace content {
namespace { namespace {
...@@ -103,10 +107,16 @@ class LockManagerBrowserTest : public ContentBrowserTest { ...@@ -103,10 +107,16 @@ class LockManagerBrowserTest : public ContentBrowserTest {
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
// Don't run the test if we couldn't override BrowserClient. It happens only // Don't run the test if we couldn't override BrowserClient. It happens only
// on Android Kitkat or older systems. // on Android Kitkat or older systems.
return !!original_client_; if (!original_client_)
#else return false;
return true;
// TODO(https://crbug.com/1011765): Navigation fails on Android Kit Kat.
if (base::android::BuildInfo::GetInstance()->sdk_int() <=
base::android::SDK_VERSION_KITKAT) {
return false;
}
#endif #endif
return true;
} }
GURL GetLocksURL(const std::string& hostname) const { GURL GetLocksURL(const std::string& hostname) const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment