[code coverage] Set up Windows 10 coverage builder.

Also extract common full-codebase coverage properties to a mixin.

Bug: 1010702
Change-Id: If60cc49c9040702e4f8138d46af74bbd89e204d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834951
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704919}

infra/config/cr-buildbucket.cfg

@@ -960,6 +960,14 @@ builder_mixins {
   dimensions: "ssd:0"
 }
 
+builder_mixins {
+  name: "full-codebase-coverage"
+  mixins: "code-coverage"
+  mixins: "builderless"
+  dimensions: "ssd:1"
+  dimensions: "cores:32"
+}
+
 buckets {
   name: "ci"
   acl_sets: "ci"
@@ -1197,12 +1205,9 @@ buckets {
 
     builders {
       name: "android-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "java-coverage"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -1543,13 +1548,9 @@ buckets {
 
     builders {
       name: "chromeos-vm-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "clang-coverage"
-      mixins: "fyi-ci"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -1567,13 +1568,9 @@ buckets {
 
     builders {
       name: "linux-chromeos-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "clang-coverage"
-      mixins: "fyi-ci"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -2284,6 +2281,12 @@ buckets {
       mixins: "win-ci"
       mixins: "deterministic"
     }
+    builders {
+      name: "win10-code-coverage"
+      mixins: "full-codebase-coverage"
+      mixins: "clang-coverage"
+      dimensions: "os:Windows-10"
+    }
 
     # chromium.clang
     builders {

infra/config/generated/cr-buildbucket.cfg

@@ -960,6 +960,14 @@ builder_mixins {
   dimensions: "ssd:0"
 }
 
+builder_mixins {
+  name: "full-codebase-coverage"
+  mixins: "code-coverage"
+  mixins: "builderless"
+  dimensions: "ssd:1"
+  dimensions: "cores:32"
+}
+
 buckets {
   name: "ci"
   acl_sets: "ci"
@@ -1197,12 +1205,9 @@ buckets {
 
     builders {
       name: "android-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "java-coverage"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -1543,13 +1548,9 @@ buckets {
 
     builders {
       name: "chromeos-vm-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "clang-coverage"
-      mixins: "fyi-ci"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -1567,13 +1568,9 @@ buckets {
 
     builders {
       name: "linux-chromeos-code-coverage"
-      mixins: "code-coverage"
+      mixins: "full-codebase-coverage"
       mixins: "clang-coverage"
-      mixins: "fyi-ci"
       mixins: "linux-xenial"
-      mixins: "builderless"
-      dimensions: "cores:32"
-      dimensions: "ssd:1"
     }
 
     builders {
@@ -2284,6 +2281,12 @@ buckets {
       mixins: "win-ci"
       mixins: "deterministic"
     }
+    builders {
+      name: "win10-code-coverage"
+      mixins: "full-codebase-coverage"
+      mixins: "clang-coverage"
+      dimensions: "os:Windows-10"
+    }
 
     # chromium.clang
     builders {

infra/config/generated/luci-milo.cfg

@@ -2178,6 +2178,11 @@ consoles {
     category: "code_coverage"
     short_name: "ios"
   }
+  builders {
+    name: "buildbucket/luci.chromium.ci/win10-code-coverage"
+    category: "code_coverage"
+    short_name: "win"
+  }
   builders {
     name: "buildbucket/luci.chromium.ci/ios-simulator-cronet"
     category: "cronet"

infra/config/generated/luci-scheduler.cfg

@@ -401,6 +401,7 @@ trigger {
   triggers: "win-jumbo-rel"
   triggers: "win-archive-rel"
   triggers: "win-pixel-builder-rel"
+  triggers: "win10-code-coverage" # TODO(crbug.com/1010732) Move when stable.
   triggers: "win32-arm64-rel"
   triggers: "win32-archive-dbg"
   triggers: "win32-archive-rel"
@@ -3213,6 +3214,16 @@ job {
   }
 }
 
+job {
+  id: "win10-code-coverage"
+  acl_sets: "default"
+  buildbucket: {
+    server: "cr-buildbucket.appspot.com"
+    bucket: "luci.chromium.ci"
+    builder: "win10-code-coverage"
+  }
+}
+
 job {
   id: "win-asan"
   acl_sets: "default"

infra/config/luci-milo.cfg

@@ -2178,6 +2178,11 @@ consoles {
     category: "code_coverage"
     short_name: "ios"
   }
+  builders {
+    name: "buildbucket/luci.chromium.ci/win10-code-coverage"
+    category: "code_coverage"
+    short_name: "win"
+  }
   builders {
     name: "buildbucket/luci.chromium.ci/ios-simulator-cronet"
     category: "cronet"

infra/config/luci-scheduler.cfg

@@ -401,6 +401,7 @@ trigger {
   triggers: "win-jumbo-rel"
   triggers: "win-archive-rel"
   triggers: "win-pixel-builder-rel"
+  triggers: "win10-code-coverage" # TODO(crbug.com/1010732) Move when stable.
   triggers: "win32-arm64-rel"
   triggers: "win32-archive-dbg"
   triggers: "win32-archive-rel"
@@ -3213,6 +3214,16 @@ job {
   }
 }
 
+job {
+  id: "win10-code-coverage"
+  acl_sets: "default"
+  buildbucket: {
+    server: "cr-buildbucket.appspot.com"
+    bucket: "luci.chromium.ci"
+    builder: "win10-code-coverage"
+  }
+}
+
 job {
   id: "win-asan"
   acl_sets: "default"

testing/buildbot/waterfalls.pyl

@@ -2058,6 +2058,14 @@
           'isolated_scripts': 'chromium_webkit_isolated_scripts',
         },
       },
+      'win10-code-coverage': {
+        'mixins': [
+          'code-coverage',
+        ],
+        'test_suites': {
+          'gtest_tests': 'chromium_win_gtests',
+        }
+      },
       'win32-archive-rel-goma-canary-localoutputcache': {
         'additional_compile_targets': [
           'all',

tools/mb/mb_config.pyl

@@ -327,6 +327,7 @@
       'win-password-manager-captured-sites-rel': 'release_bot',
       'win-pixel-builder-rel': 'release_bot',
       'win32-arm64-rel': 'win32_arm64_release_bot',
+      'win10-code-coverage': 'clang_code_coverage_nofuzzer',
     },
 
     'chromium.goma': {
@@ -1323,6 +1324,10 @@
       'use_clang_coverage', 'debug_static_bot', 'x64', 'ios'
     ],
 
+    'clang_code_coverage_nofuzzer': [
+      'release_bot', 'clang', 'use_clang_coverage', 'no_symbols',
+    ],
+
     'clang_tot_asan_lsan_static_release': [
       'clang_tot', 'asan', 'lsan', 'static', 'release',
     ],