Commit 6a02ba8c authored by Klaus Weidner's avatar Klaus Weidner Committed by Commit Bot

Revert "Ensure that detached GraphicsLayers trigger invalidation"

This reverts commit b5a76458.

Reason for revert: blamed for performance regression: https://crbug.com/1005368

The graphs look fairly unambiguous that this CL is at fault.

Original change's description:
> Ensure that detached GraphicsLayers trigger invalidation
>
> GraphicsLayers in this state will not have GraphicsLayer::Paint called on them,
> and Paint updates the GraphicsLayer's display item's references back to the
> layout tree.
>
> Bug: 991747
> Change-Id: I468c0b691fdc8c85414e56dcc6c8a733e666ccc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802823
> Commit-Queue: Klaus Weidner <klausw@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#696449}

TBR=pdr@chromium.org,klausw@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991747
Change-Id: I3af1ffa4db9f7b83d20503b63c3df31d1ea159e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810455
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697899}
parent 1ed2d67b
......@@ -209,13 +209,6 @@ void GraphicsLayer::RemoveFromParent() {
SetParent(nullptr);
}
// Avoid inconsistencies for detached content since GraphicsLayers in that
// state will not have GraphicsLayer::Paint called on them, and Paint updates
// the GraphicsLayer's display item's references back to the layout tree.
// Only do this if there's a paint controller.
if (PaintsContentOrHitTest())
GetPaintController().InvalidateAll();
// cc::Layers are created and removed in PaintArtifactCompositor so ensure it
// is notified that something has changed.
client_.GraphicsLayersDidChange();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment