Commit 6a06cd08 authored by Ossama Mahmoud's avatar Ossama Mahmoud Committed by Commit Bot

OOBE: Update Fingerprint Enrollment aria_label

Currently, in the fingerprint enrollment flow we instruct the users to
place their fingers either on the power button or on the fingerprint
sensor without specifying the exact location of the fingerprint sensor

In this CL, the aria_labels are updated to provide the users with the
exact location of the fingerprint sensor on their devices.

Bug: 1146413
Change-Id: Ibbf8bb23485380a0be17fbe29f03c3f69df2bb98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523323
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Ossama Mahmoud <osamafathy@google.com>
Reviewed-by: default avatarDenis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825085}
parent 8e7349a7
......@@ -21,7 +21,7 @@
has-buttons footer-shrinkable
title-key="placeFingerScreenTitle"
subtitle-key="setupFingerprintScreenDescription"
aria-label$="[[i18nDynamic(locale, 'placeFingerScreenTitle')]]">
aria-label$="[[i18nDynamic(locale, 'setupFingerprintScreenAriaLabel')]]">
<hd-iron-icon slot="oobe-icon"
icon1x="oobe-32:fingerprint" icon2x="oobe-64:fingerprint">
</hd-iron-icon>
......
......@@ -173,7 +173,6 @@ Polymer({
* Enable/disable lottie animation.
* @param {boolean} playing True if animation should be playing.
*/
setAnimationState_(playing) {
if (this.shouldUseLottieAnimation_) {
const lottieElement = /** @type{CrLottieElement} */ (
......
......@@ -44,20 +44,36 @@ void FingerprintSetupScreenHandler::DeclareLocalizedValues(
IDS_OOBE_FINGERPINT_SETUP_SCREEN_INSTRUCTION_MOVE_FINGER);
builder->Add("setupFingerprintScanTryAgain",
IDS_OOBE_FINGERPINT_SETUP_SCREEN_INSTRUCTION_TRY_AGAIN);
int description_id;
int description_id, aria_label_id;
switch (quick_unlock::GetFingerprintLocation()) {
case quick_unlock::FingerprintLocation::TABLET_POWER_BUTTON:
description_id =
IDS_OOBE_FINGERPINT_SETUP_SCREEN_SENSOR_POWER_BUTTON_DESCRIPTION;
aria_label_id =
IDS_SETTINGS_ADD_FINGERPRINT_DIALOG_INSTRUCTION_LOCATE_SCANNER_POWER_BUTTON_ARIA_LABEL;
break;
case quick_unlock::FingerprintLocation::KEYBOARD_BOTTOM_LEFT:
description_id =
IDS_OOBE_FINGERPINT_SETUP_SCREEN_SENSOR_GENERAL_DESCRIPTION;
aria_label_id =
IDS_SETTINGS_ADD_FINGERPRINT_DIALOG_INSTRUCTION_LOCATE_SCANNER_KEYBOARD_BOTTOM_LEFT_ARIA_LABEL;
break;
case quick_unlock::FingerprintLocation::KEYBOARD_BOTTOM_RIGHT:
description_id =
IDS_OOBE_FINGERPINT_SETUP_SCREEN_SENSOR_GENERAL_DESCRIPTION;
aria_label_id =
IDS_SETTINGS_ADD_FINGERPRINT_DIALOG_INSTRUCTION_LOCATE_SCANNER_KEYBOARD_BOTTOM_RIGHT_ARIA_LABEL;
break;
case quick_unlock::FingerprintLocation::KEYBOARD_TOP_RIGHT:
description_id =
IDS_OOBE_FINGERPINT_SETUP_SCREEN_SENSOR_GENERAL_DESCRIPTION;
aria_label_id =
IDS_SETTINGS_ADD_FINGERPRINT_DIALOG_INSTRUCTION_LOCATE_SCANNER_KEYBOARD_TOP_RIGHT_ARIA_LABEL;
break;
}
builder->Add("setupFingerprintScreenDescription", description_id);
builder->Add("setupFingerprintScreenAriaLabel", aria_label_id);
}
void FingerprintSetupScreenHandler::RegisterMessages() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment