Skip to content

GitLab

T
tangled
Commit 6a600583 authored by manuk's avatar manuk Committed by Commit Bot
Browse files
Options

[Omnibox] When in keyword mode, don't allow shortcut matches of different... 

[Omnibox] When in keyword mode, don't allow shortcut matches of different keywords to be the default match.

Prior to this cl, when the user has searched for `searchProvder searchTerm` (not in keyword mode) then typing in `searchProvider `, entering keyword mode, and typing `s` could result in the shortcut match for the earlier search becoming the default match and causing him to leave keyword mode.

Bug: 632215
Change-Id: I19ee38e3e5c9ee68f8f7703afccef1276027b521
Reviewed-on: https://chromium-review.googlesource.com/c/1182295
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597202}
parent f9bb833d
Show whitespace changes
Inline Side-by-side
Showing with 169 additions and 164 deletions
chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
View file @ 6a600583
...@@ -41,7 +41,7 @@ struct TestShortcutData shortcut_test_db[] = { ...@@ -41,7 +41,7 @@ struct TestShortcutData shortcut_test_db[] = {
{"BD85DBA2-8C29-49F9-84AE-48E1E90880F1", "echo echo", "echo echo", {"BD85DBA2-8C29-49F9-84AE-48E1E90880F1", "echo echo", "echo echo",
"chrome-extension://cedabbhfglmiikkmdgcpjdkocfcmbkee/?q=echo", "chrome-extension://cedabbhfglmiikkmdgcpjdkocfcmbkee/?q=echo",
"Run Echo command: echo", "0,0", "Echo", "0,4", ui::PAGE_TRANSITION_TYPED, "Run Echo command: echo", "0,0", "Echo", "0,4", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::EXTENSION_APP_DEPRECATED, "echo", 1, 1}, AutocompleteMatchType::EXTENSION_APP_DEPRECATED, "", 1, 1},
}; };
} // namespace } // namespace
......
components/omnibox/browser/shortcuts_provider.cc
View file @ 6a600583
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
...@@ -388,15 +389,31 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch( ...@@ -388,15 +389,31 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch(
base::UTF16ToUTF8(shortcut.text)); base::UTF16ToUTF8(shortcut.text));
// Set |inline_autocompletion| and |allowed_to_be_default_match| if possible. // Set |inline_autocompletion| and |allowed_to_be_default_match| if possible.
// If the match is a search query this is easy: simply check whether the // If the input is in keyword mode, navigation matches cannot be the default
// user text is a prefix of the query. If the match is a navigation, we // match, and search query matches can only be the default match if their
// assume the fill_into_edit looks something like a URL, so we use // keywords matches the input's keyword, as otherwise, default,
// URLPrefix::GetInlineAutocompleteOffset() to try and strip off any prefixes // different-keyword matches may result in leaving keyword mode. Additionally,
// that the user might not think would change the meaning, but would // if the match is a search query, check whether the user text is a prefix of
// otherwise prevent inline autocompletion. This allows, for example, the // the query. If the match is a navigation, we assume the fill_into_edit looks
// input of "foo.c" to autocomplete to "foo.com" for a fill_into_edit of // something like a URL, so we use URLPrefix::GetInlineAutocompleteOffset() to
// "http://foo.com". // try and strip off any prefixes that the user might not think would change
// the meaning, but would otherwise prevent inline autocompletion. This
// allows, for example, the input of "foo.c" to autocomplete to "foo.com" for
// a fill_into_edit of "http://foo.com".
const bool is_search_type = AutocompleteMatch::IsSearchType(match.type); const bool is_search_type = AutocompleteMatch::IsSearchType(match.type);
DCHECK(is_search_type != match.keyword.empty());
// True if input is in keyword mode and the match is a URL suggestion or the
// match has a different keyword.
bool would_cause_leaving_keyboard_mode =
input.prefer_keyword() &&
(!is_search_type ||
!base::StartsWith(base::UTF16ToUTF8(input.text()),
base::StrCat({base::UTF16ToUTF8(match.keyword), " "}),
base::CompareCase::INSENSITIVE_ASCII));
if (!would_cause_leaving_keyboard_mode) {
if (is_search_type) { if (is_search_type) {
if (match.fill_into_edit.size() >= input.text().size() && if (match.fill_into_edit.size() >= input.text().size() &&
std::equal(match.fill_into_edit.begin(), std::equal(match.fill_into_edit.begin(),
...@@ -421,6 +438,7 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch( ...@@ -421,6 +438,7 @@ AutocompleteMatch ShortcutsProvider::ShortcutToACMatch(
match.inline_autocompletion.empty(); match.inline_autocompletion.empty();
} }
} }
}
// Try to mark pieces of the contents and description as matches if they // Try to mark pieces of the contents and description as matches if they
// appear in |input.text()|. // appear in |input.text()|.
......
components/omnibox/browser/shortcuts_provider_unittest.cc
View file @ 6a600583
...@@ -39,139 +39,126 @@ using ExpectedURLs = std::vector<ExpectedURLAndAllowedToBeDefault>; ...@@ -39,139 +39,126 @@ using ExpectedURLs = std::vector<ExpectedURLAndAllowedToBeDefault>;
namespace { namespace {
struct TestShortcutData shortcut_test_db[] = { struct TestShortcutData shortcut_test_db[] = {
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E0", "goog", "www.google.com", {"BD85DBA2-8C29-49F9-84AE-48E1E90880E0", "goog", "www.google.com",
"http://www.google.com/", "Google", "0,1,4,0", "Google", "0,3,4,1", "http://www.google.com/", "Google", "0,1,4,0", "Google", "0,3,4,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E1", "slash", "slashdot.org",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E1", "slash", "slashdot.org",
"http://slashdot.org/", "slashdot.org", "0,3,5,1", "http://slashdot.org/", "slashdot.org", "0,3,5,1",
"Slashdot - News for nerds, stuff that matters", "0,2,5,0", "Slashdot - News for nerds, stuff that matters", "0,2,5,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 0, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 0, 100},
100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E2", "news", "slashdot.org",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E2", "news", "slashdot.org",
"http://slashdot.org/", "slashdot.org", "0,1", "http://slashdot.org/", "slashdot.org", "0,1",
"Slashdot - News for nerds, stuff that matters", "0,0,11,2,15,0", "Slashdot - News for nerds, stuff that matters", "0,0,11,2,15,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 0, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 0, 5},
5 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E3", "news", "sports.yahoo.com",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E3", "news", "sports.yahoo.com",
"http://sports.yahoo.com/", "sports.yahoo.com", "0,1", "http://sports.yahoo.com/", "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more", "Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,23,2,27,0", ui::PAGE_TRANSITION_TYPED, "0,0,23,2,27,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 2, 5 }, AutocompleteMatchType::HISTORY_TITLE, "", 2, 5},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E4", "news weather", {"BD85DBA2-8C29-49F9-84AE-48E1E90880E4", "news weather",
"www.cnn.com/index.html", "http://www.cnn.com/index.html", "www.cnn.com/index.html", "http://www.cnn.com/index.html",
"www.cnn.com/index.html", "0,1", "www.cnn.com/index.html", "0,1",
"CNN.com - Breaking News, U.S., World, Weather, Entertainment & Video", "CNN.com - Breaking News, U.S., World, Weather, Entertainment & Video",
"0,0,19,2,23,0,38,2,45,0", ui::PAGE_TRANSITION_TYPED, "0,0,19,2,23,0,38,2,45,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 1, 10 }, AutocompleteMatchType::HISTORY_TITLE, "", 1, 10},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E5", "nhl scores", "sports.yahoo.com", {"BD85DBA2-8C29-49F9-84AE-48E1E90880E5", "nhl scores", "sports.yahoo.com",
"http://sports.yahoo.com/", "sports.yahoo.com", "0,1", "http://sports.yahoo.com/", "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more", "Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,29,2,35,0", ui::PAGE_TRANSITION_TYPED, "0,0,29,2,35,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_BODY, "", 1, 10 }, AutocompleteMatchType::HISTORY_BODY, "", 1, 10},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E6", "nhl scores", {"BD85DBA2-8C29-49F9-84AE-48E1E90880E6", "nhl scores",
"www.nhl.com/scores/index.html", "http://www.nhl.com/scores/index.html", "www.nhl.com/scores/index.html", "http://www.nhl.com/scores/index.html",
"www.nhl.com/scores/index.html", "0,1,4,3,7,1", "www.nhl.com/scores/index.html", "0,1,4,3,7,1",
"January 13, 2010 - NHL.com - Scores", "0,0,19,2,22,0,29,2,35,0", "January 13, 2010 - NHL.com - Scores", "0,0,19,2,22,0,29,2,35,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 5, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 5, 1},
1 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E7", "just", "www.testsite.com/a.html",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E7", "just", "www.testsite.com/a.html",
"http://www.testsite.com/a.html", "www.testsite.com/a.html", "0,1", "http://www.testsite.com/a.html", "www.testsite.com/a.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0", "Test - site - just a test", "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 5, AutocompleteMatchType::HISTORY_TITLE, "", 5, 1},
1 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E8", "just", "www.testsite.com/b.html",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E8", "just", "www.testsite.com/b.html",
"http://www.testsite.com/b.html", "www.testsite.com/b.html", "0,1", "http://www.testsite.com/b.html", "www.testsite.com/b.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0", "Test - site - just a test", "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 5, AutocompleteMatchType::HISTORY_TITLE, "", 5, 2},
2 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880E9", "just", "www.testsite.com/c.html",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E9", "just", "www.testsite.com/c.html",
"http://www.testsite.com/c.html", "www.testsite.com/c.html", "0,1", "http://www.testsite.com/c.html", "www.testsite.com/c.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0", "Test - site - just a test", "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 8, AutocompleteMatchType::HISTORY_TITLE, "", 8, 1},
1 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880EA", "just a",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EA", "just a", "www.testsite.com/d.html", "www.testsite.com/d.html", "http://www.testsite.com/d.html",
"http://www.testsite.com/d.html", "www.testsite.com/d.html", "0,1", "www.testsite.com/d.html", "0,1", "Test - site - just a test",
"Test - site - just a test", "0,0,14,2,18,0", "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
12, 1 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880EB", "just a t",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EB", "just a t",
"www.testsite.com/e.html", "http://www.testsite.com/e.html", "www.testsite.com/e.html", "http://www.testsite.com/e.html",
"www.testsite.com/e.html", "0,1", "Test - site - just a test", "www.testsite.com/e.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED, "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1 }, AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EC", "just a te", {"BD85DBA2-8C29-49F9-84AE-48E1E90880EC", "just a te",
"www.testsite.com/f.html", "http://www.testsite.com/f.html", "www.testsite.com/f.html", "http://www.testsite.com/f.html",
"www.testsite.com/f.html", "0,1", "Test - site - just a test", "www.testsite.com/f.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED, "0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1 }, AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880ED", "ago", "www.daysagotest.com/a.html", {"BD85DBA2-8C29-49F9-84AE-48E1E90880ED", "ago",
"http://www.daysagotest.com/a.html", "www.daysagotest.com/a.html", "www.daysagotest.com/a.html", "http://www.daysagotest.com/a.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED, "www.daysagotest.com/a.html", "0,1,8,3,11,1", "Test - site", "0,0",
AutocompleteMatchType::HISTORY_URL, "", 1, 1 }, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EE", "ago", "www.daysagotest.com/b.html", {"BD85DBA2-8C29-49F9-84AE-48E1E90880EE", "ago",
"http://www.daysagotest.com/b.html", "www.daysagotest.com/b.html", "www.daysagotest.com/b.html", "http://www.daysagotest.com/b.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED, "www.daysagotest.com/b.html", "0,1,8,3,11,1", "Test - site", "0,0",
AutocompleteMatchType::HISTORY_URL, "", 2, 1 }, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 2, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EF", "ago", "www.daysagotest.com/c.html", {"BD85DBA2-8C29-49F9-84AE-48E1E90880EF", "ago",
"http://www.daysagotest.com/c.html", "www.daysagotest.com/c.html", "www.daysagotest.com/c.html", "http://www.daysagotest.com/c.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED, "www.daysagotest.com/c.html", "0,1,8,3,11,1", "Test - site", "0,0",
AutocompleteMatchType::HISTORY_URL, "", 3, 1 }, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 3, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F0", "ago", "www.daysagotest.com/d.html", {"BD85DBA2-8C29-49F9-84AE-48E1E90880F0", "ago",
"http://www.daysagotest.com/d.html", "www.daysagotest.com/d.html", "www.daysagotest.com/d.html", "http://www.daysagotest.com/d.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED, "www.daysagotest.com/d.html", "0,1,8,3,11,1", "Test - site", "0,0",
AutocompleteMatchType::HISTORY_URL, "", 4, 1 }, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 4, 1},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F2", "abcdef.com", "http://abcdef.com", {"BD85DBA2-8C29-49F9-84AE-48E1E90880F2", "abcdef.com", "http://abcdef.com",
"http://abcdef.com/", "Abcdef", "0,1,4,0", "Abcdef", "0,3,4,1", "http://abcdef.com/", "Abcdef", "0,1,4,0", "Abcdef", "0,3,4,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F3", "query", "query",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F3", "query", "query", "https://www.google.com/search?q=query", "query", "0,0", "Google Search",
"https://www.google.com/search?q=query", "query", "0,0", "0,4", ui::PAGE_TRANSITION_GENERATED,
"Google Search", "0,4", ui::PAGE_TRANSITION_GENERATED, AutocompleteMatchType::SEARCH_HISTORY, "google.com", 1, 100},
AutocompleteMatchType::SEARCH_HISTORY, "", 1, 100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F4", "word", "www.word",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F4", "word", "www.word",
"https://www.google.com/search?q=www.word", "www.word", "0,0", "https://www.google.com/search?q=www.word", "www.word", "0,0",
"Google Search", "0,4", ui::PAGE_TRANSITION_GENERATED, "Google Search", "0,4", ui::PAGE_TRANSITION_GENERATED,
AutocompleteMatchType::SEARCH_HISTORY, "", 1, 100 }, AutocompleteMatchType::SEARCH_HISTORY, "google.com", 1, 100},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F5", "about:o", "chrome://omnibox", {"BD85DBA2-8C29-49F9-84AE-48E1E90880F5", "about:o", "chrome://omnibox",
"chrome://omnibox/", "about:omnibox", "0,3,10,1", "", "", "chrome://omnibox/", "about:omnibox", "0,3,10,1", "", "",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::NAVSUGGEST, "", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::NAVSUGGEST, "", 1, 100},
1, 100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F6", "www/real sp",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F6", "www/real sp",
"http://www/real space/long-url-with-space.html", "http://www/real space/long-url-with-space.html",
"http://www/real%20space/long-url-with-space.html", "http://www/real%20space/long-url-with-space.html",
"www/real space/long-url-with-space.html", "0,3,11,1", "www/real space/long-url-with-space.html", "0,3,11,1",
"Page With Space; Input with Space", "0,0", "Page With Space; Input with Space", "0,0", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", AutocompleteMatchType::HISTORY_URL, "", 1, 100},
1, 100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F7", "duplicate",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F7", "duplicate", "http://duplicate.com", "http://duplicate.com", "http://duplicate.com/", "Duplicate", "0,1",
"http://duplicate.com/", "Duplicate", "0,1", "Duplicate", "0,1", "Duplicate", "0,1", ui::PAGE_TRANSITION_TYPED,
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F8", "dupl", "http://duplicate.com",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F8", "dupl", "http://duplicate.com",
"http://duplicate.com/", "Duplicate", "0,1", "Duplicate", "0,1", "http://duplicate.com/", "Duplicate", "0,1", "Duplicate", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880F9", "notrailing.com/",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F9", "notrailing.com/",
"http://notrailing.com", "http://notrailing.com/", "No Trailing Slash", "http://notrailing.com", "http://notrailing.com/", "No Trailing Slash",
"0,1", "No Trailing Slash on fill_into_edit", "0,1", "0,1", "No Trailing Slash on fill_into_edit", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
1, 100 }, {"BD85DBA2-8C29-49F9-84AE-48E1E90880FA", "http:///foo.com",
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FA", "http:///foo.com", "http://foo.com", "http://foo.com/", "Foo - Typo in Input", "0,1",
"http://foo.com", "http://foo.com/", "Foo - Typo in Input", "Foo - Typo in Input Corrected in fill_into_edit", "0,1",
"0,1", "Foo - Typo in Input Corrected in fill_into_edit", "0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", {"BD85DBA2-8C29-49F9-84AE-48E1E90880FB", "trailing1 ",
1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FB", "trailing1 ",
"http://trailing1.com", "http://trailing1.com/", "http://trailing1.com", "http://trailing1.com/",
"Trailing1 - Space in Shortcut", "0,1", "Trailing1 - Space in Shortcut", "0,1", "Trailing1 - Space in Shortcut",
"Trailing1 - Space in Shortcut", "0,1", ui::PAGE_TRANSITION_TYPED, "0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
AutocompleteMatchType::HISTORY_URL, "", 1, 100 }, 1, 100},
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FC", "about:trailing2 ", {"BD85DBA2-8C29-49F9-84AE-48E1E90880FC", "about:trailing2 ",
"chrome://trailing2blah", "chrome://trailing2blah/", "chrome://trailing2blah", "chrome://trailing2blah/",
"Trailing2 - Space in Shortcut", "0,1", "Trailing2 - Space in Shortcut", "0,1", "Trailing2 - Space in Shortcut",
"Trailing2 - Space in Shortcut", "0,1", ui::PAGE_TRANSITION_TYPED, "0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
AutocompleteMatchType::HISTORY_URL, "", 1, 100 }, 1, 100},
}; };
} // namespace } // namespace
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment