Commit 6ac5174c authored by Uladzimir Miniailau's avatar Uladzimir Miniailau Committed by Commit Bot

kEnableManualFallbacksGeneration -> kManualFallbacksGeneration

Remove unnecessary "Enable" from a password manager feature name.

Bug: 785953
Change-Id: I7c979dc97e34595db69976d673c0afe31aceb879
Reviewed-on: https://chromium-review.googlesource.com/1106377Reviewed-by: default avatarVaclav Brozek <vabr@chromium.org>
Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
Cr-Commit-Position: refs/heads/master@{#568769}
parent f2f52709
...@@ -151,7 +151,7 @@ class PasswordGenerationAgentTest : public ChromeRenderViewTest { ...@@ -151,7 +151,7 @@ class PasswordGenerationAgentTest : public ChromeRenderViewTest {
void EnableManualGenerationFallback() { void EnableManualGenerationFallback() {
scoped_feature_list_.InitAndEnableFeature( scoped_feature_list_.InitAndEnableFeature(
password_manager::features::kEnableManualFallbacksGeneration); password_manager::features::kManualFallbacksGeneration);
} }
FakeContentPasswordManagerDriver fake_driver_; FakeContentPasswordManagerDriver fake_driver_;
......
...@@ -266,7 +266,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions( ...@@ -266,7 +266,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(
show_all_saved_passwords_shown_context_); show_all_saved_passwords_shown_context_);
} }
if (base::FeatureList::IsEnabled( if (base::FeatureList::IsEnabled(
password_manager::features::kEnableManualFallbacksGeneration) && password_manager::features::kManualFallbacksGeneration) &&
password_manager_util::GetPasswordSyncState( password_manager_util::GetPasswordSyncState(
autofill_client_->GetSyncService()) == SYNCING_NORMAL_ENCRYPTION) { autofill_client_->GetSyncService()) == SYNCING_NORMAL_ENCRYPTION) {
AddSimpleSuggestionWithSeparatorOnTop( AddSimpleSuggestionWithSeparatorOnTop(
...@@ -307,7 +307,7 @@ void PasswordAutofillManager::OnShowManualFallbackSuggestion( ...@@ -307,7 +307,7 @@ void PasswordAutofillManager::OnShowManualFallbackSuggestion(
show_all_saved_passwords_shown_context_); show_all_saved_passwords_shown_context_);
if (base::FeatureList::IsEnabled( if (base::FeatureList::IsEnabled(
password_manager::features::kEnableManualFallbacksGeneration) && password_manager::features::kManualFallbacksGeneration) &&
password_manager_util::GetPasswordSyncState( password_manager_util::GetPasswordSyncState(
autofill_client_->GetSyncService()) == SYNCING_NORMAL_ENCRYPTION) { autofill_client_->GetSyncService()) == SYNCING_NORMAL_ENCRYPTION) {
AddSimpleSuggestionWithSeparatorOnTop( AddSimpleSuggestionWithSeparatorOnTop(
......
...@@ -196,7 +196,7 @@ class PasswordAutofillManagerTest : public testing::Test { ...@@ -196,7 +196,7 @@ class PasswordAutofillManagerTest : public testing::Test {
password_manager::features::kManualFallbacksFilling.name, password_manager::features::kManualFallbacksFilling.name,
password_manager::features::kManualFallbacksFillingStandalone password_manager::features::kManualFallbacksFillingStandalone
.name, .name,
password_manager::features::kEnableManualFallbacksGeneration.name}; password_manager::features::kManualFallbacksGeneration.name};
if (enabled) { if (enabled) {
scoped_feature_list_.InitFromCommandLine(base::JoinString(features, ","), scoped_feature_list_.InitFromCommandLine(base::JoinString(features, ","),
std::string()); std::string());
......
...@@ -20,8 +20,8 @@ const base::Feature kHtmlBasedUsernameDetector = { ...@@ -20,8 +20,8 @@ const base::Feature kHtmlBasedUsernameDetector = {
// Enable additional elements in the form popup UI, which will allow the user to // Enable additional elements in the form popup UI, which will allow the user to
// view all saved passwords. // view all saved passwords.
const base::Feature kEnableManualFallbacksGeneration = { const base::Feature kManualFallbacksGeneration = {
"EnableManualFallbacksGeneration", base::FEATURE_DISABLED_BY_DEFAULT}; "ManualFallbacksGeneration", base::FEATURE_DISABLED_BY_DEFAULT};
// Enable additional elements in the form popup UI, which will allow the user to // Enable additional elements in the form popup UI, which will allow the user to
// trigger generation or view all saved passwords. // trigger generation or view all saved passwords.
......
...@@ -21,7 +21,7 @@ extern const base::Feature kAffiliationBasedMatching; ...@@ -21,7 +21,7 @@ extern const base::Feature kAffiliationBasedMatching;
extern const base::Feature kHtmlBasedUsernameDetector; extern const base::Feature kHtmlBasedUsernameDetector;
extern const base::Feature kManualFallbacksFilling; extern const base::Feature kManualFallbacksFilling;
extern const base::Feature kManualFallbacksFillingStandalone; extern const base::Feature kManualFallbacksFillingStandalone;
extern const base::Feature kEnableManualFallbacksGeneration; extern const base::Feature kManualFallbacksGeneration;
extern const base::Feature kEnableManualPasswordGeneration; extern const base::Feature kEnableManualPasswordGeneration;
extern const base::Feature kPasswordGenerationRequirements; extern const base::Feature kPasswordGenerationRequirements;
extern const base::Feature kPasswordGenerationRequirementsDomainOverrides; extern const base::Feature kPasswordGenerationRequirementsDomainOverrides;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment