Commit 6b2059fe authored by Henrique Nakashima's avatar Henrique Nakashima Committed by Commit Bot

Update comments in //extensions about BrowserContextKeyed_Base_Factory.

These comments that say "BrowserContextKeyed_Base_Factory" are outdated
and should refer to "BrowserContextKeyed_Service_Factory" instead.

Bug: 937770
Change-Id: Ib851fcf251c064a59bdb79d5cf718712654a602c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574422Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652283}
parent deea48bc
...@@ -24,7 +24,7 @@ class DisplaySourceEventRouterFactory ...@@ -24,7 +24,7 @@ class DisplaySourceEventRouterFactory
static DisplaySourceEventRouterFactory* GetInstance(); static DisplaySourceEventRouterFactory* GetInstance();
protected: protected:
// BrowserContextKeyedBaseFactory overrides: // BrowserContextKeyedServiceFactory overrides:
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
bool ServiceIsCreatedWithBrowserContext() const override; bool ServiceIsCreatedWithBrowserContext() const override;
......
...@@ -27,7 +27,7 @@ class IdleManagerFactory : public BrowserContextKeyedServiceFactory { ...@@ -27,7 +27,7 @@ class IdleManagerFactory : public BrowserContextKeyedServiceFactory {
IdleManagerFactory(); IdleManagerFactory();
~IdleManagerFactory() override; ~IdleManagerFactory() override;
// BrowserContextKeyedBaseFactory implementation. // BrowserContextKeyedServiceFactory implementation.
KeyedService* BuildServiceInstanceFor( KeyedService* BuildServiceInstanceFor(
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
......
...@@ -29,7 +29,7 @@ class NetworkingConfigServiceFactory ...@@ -29,7 +29,7 @@ class NetworkingConfigServiceFactory
NetworkingConfigServiceFactory(); NetworkingConfigServiceFactory();
~NetworkingConfigServiceFactory() override; ~NetworkingConfigServiceFactory() override;
// BrowserContextKeyedBaseFactory // BrowserContextKeyedServiceFactory
KeyedService* BuildServiceInstanceFor( KeyedService* BuildServiceInstanceFor(
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
......
...@@ -28,7 +28,7 @@ class NetworkingPrivateEventRouterFactory ...@@ -28,7 +28,7 @@ class NetworkingPrivateEventRouterFactory
static NetworkingPrivateEventRouterFactory* GetInstance(); static NetworkingPrivateEventRouterFactory* GetInstance();
protected: protected:
// BrowserContextKeyedBaseFactory overrides: // BrowserContextKeyedServiceFactory overrides:
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
bool ServiceIsCreatedWithBrowserContext() const override; bool ServiceIsCreatedWithBrowserContext() const override;
......
...@@ -19,13 +19,13 @@ class BrowserContextKeyedAPIFactory; ...@@ -19,13 +19,13 @@ class BrowserContextKeyedAPIFactory;
// Instantiations of BrowserContextKeyedAPIFactory should use this base class // Instantiations of BrowserContextKeyedAPIFactory should use this base class
// and also define a static const char* service_name() function (used in the // and also define a static const char* service_name() function (used in the
// BrowserContextKeyedBaseFactory constructor). These fields should // BrowserContextKeyedServiceFactory constructor). These fields should
// be accessible to the BrowserContextKeyedAPIFactory for the service. // be accessible to the BrowserContextKeyedAPIFactory for the service.
class BrowserContextKeyedAPI : public KeyedService { class BrowserContextKeyedAPI : public KeyedService {
protected: protected:
// Defaults for flags that control BrowserContextKeyedAPIFactory behavior. // Defaults for flags that control BrowserContextKeyedAPIFactory behavior.
// These can be overridden by subclasses to change that behavior. // These can be overridden by subclasses to change that behavior.
// See BrowserContextKeyedBaseFactory for usage. // See BrowserContextKeyedServiceFactory for usage.
// These flags affect what instance is returned when Get() is called // These flags affect what instance is returned when Get() is called
// on an incognito profile. By default, it returns NULL. If // on an incognito profile. By default, it returns NULL. If
...@@ -36,7 +36,7 @@ class BrowserContextKeyedAPI : public KeyedService { ...@@ -36,7 +36,7 @@ class BrowserContextKeyedAPI : public KeyedService {
static const bool kServiceHasOwnInstanceInIncognito = false; static const bool kServiceHasOwnInstanceInIncognito = false;
// If set to false, don't start the service at BrowserContext creation time. // If set to false, don't start the service at BrowserContext creation time.
// (The default differs from the BrowserContextKeyedBaseFactory default, // (The default differs from the BrowserContextKeyedServiceFactory default,
// because historically, BrowserContextKeyedAPIs often do tasks at startup.) // because historically, BrowserContextKeyedAPIs often do tasks at startup.)
static const bool kServiceIsCreatedWithBrowserContext = true; static const bool kServiceIsCreatedWithBrowserContext = true;
...@@ -137,7 +137,7 @@ class BrowserContextKeyedAPIFactory : public BrowserContextKeyedServiceFactory { ...@@ -137,7 +137,7 @@ class BrowserContextKeyedAPIFactory : public BrowserContextKeyedServiceFactory {
return new T(context); return new T(context);
} }
// BrowserContextKeyedBaseFactory implementation. // BrowserContextKeyedServiceFactory implementation.
// These can be effectively overridden with template specializations. // These can be effectively overridden with template specializations.
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override { content::BrowserContext* context) const override {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment