Skip to content

GitLab

T
tangled
Commit 6b7c2f80 authored by viettrungluu@chromium.org's avatar viettrungluu@chromium.org
Browse files
Options

Remove DeferredResourceLoadingTest's use of *named* shared memory. 

It's totally unnecessary (and named shared memory is now deprecated).

R=jam@chromium.org

Review URL: https://codereview.chromium.org/189843009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255784 0039d316-1c4b-4281-b951-d872f2087c98
parent a02825f8
Show whitespace changes
Inline Side-by-side
Showing with 1 addition and 8 deletions
content/child/resource_dispatcher_unittest.cc
View file @ 6b7c2f80
...@@ -33,8 +33,6 @@ static const char test_page_contents[] = ...@@ -33,8 +33,6 @@ static const char test_page_contents[] =
"<html><head><title>Google</title></head><body><h1>Google</h1></body></html>"; "<html><head><title>Google</title></head><body><h1>Google</h1></body></html>";
static const uint32 test_page_contents_len = arraysize(test_page_contents) - 1; static const uint32 test_page_contents_len = arraysize(test_page_contents) - 1;
static const char kShmemSegmentName[] = "DeferredResourceLoaderTest";
// Listens for request response data and stores it so that it can be compared // Listens for request response data and stores it so that it can be compared
// to the reference data. // to the reference data.
class TestRequestCallback : public ResourceLoaderBridge::Peer { class TestRequestCallback : public ResourceLoaderBridge::Peer {
...@@ -308,16 +306,11 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest, ...@@ -308,16 +306,11 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest,
protected: protected:
virtual void SetUp() OVERRIDE { virtual void SetUp() OVERRIDE {
ResourceDispatcherTest::SetUp(); ResourceDispatcherTest::SetUp();
shared_handle_.Delete(kShmemSegmentName); EXPECT_TRUE(shared_handle_.CreateAnonymous(100));
// TODO(viettrungluu): Named shared memory is deprecated (crbug.com/345734).
// (I don't think we even need it here.)
EXPECT_TRUE(shared_handle_.CreateNamedDeprecated(kShmemSegmentName, false,
100));
} }
virtual void TearDown() OVERRIDE { virtual void TearDown() OVERRIDE {
shared_handle_.Close(); shared_handle_.Close();
EXPECT_TRUE(shared_handle_.Delete(kShmemSegmentName));
ResourceDispatcherTest::TearDown(); ResourceDispatcherTest::TearDown();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment